Added Setting to allow for disabling of video embeds. Aligns with similar settings for other content types.

Author: dfsm

App/Misc/HTMLRenderingHelpers.swift

@@ -458,8 +458,51 @@ extension HTMLDocument {
 
                     a.parent?.replace(child: a, with: videoElement)
                 }
-                            
+
+            }
+        }
+    }
+
+    /**
+     Replaces video-embed elements with plain links to the underlying URL. Pair with skipping `embedVideos()` and `useHTML5VimeoPlayer()` to honour a "don't embed videos" preference.
+     */
+    func linkifyResidualVideoEmbeds() {
+        for iframe in nodes(matchingParsedSelector: .cached("iframe[src]")) {
+            guard let src = iframe["src"], !src.isEmpty else { continue }
+            let link = HTMLElement(tagName: "a", attributes: ["href": src])
+            link.textContent = src
+            iframe.parent?.replace(child: iframe, with: link)
+        }
+
+        for video in nodes(matchingParsedSelector: .cached("video")) {
+            let src = video["src"] ?? video.firstNode(matchingParsedSelector: .cached("source[src]"))?["src"]
+            guard let src, !src.isEmpty else { continue }
+            let link = HTMLElement(tagName: "a", attributes: ["href": src])
+            link.textContent = src
+            video.parent?.replace(child: video, with: link)
+        }
+
+        for param in nodes(matchingParsedSelector: .cached("div.bbcode_video object param[name='movie']")) {
+            guard
+                let value = param["value"],
+                let object = param.parentElement,
+                object.tagName == "object",
+                let div = object.parentElement,
+                div.tagName == "div",
+                div.hasClass("bbcode_video")
+            else { continue }
+
+            let href: String
+            if let sourceURL = URL(string: value),
+               let clipID = sourceURL.valueForFirstQueryItem(named: "clip_id") {
+                href = "https://vimeo.com/\(clipID)"
+            } else {
+                href = value
             }
+
+            let link = HTMLElement(tagName: "a", attributes: ["href": href])
+            link.textContent = href
+            div.parent?.replace(child: div, with: link)
         }
     }
 }

App/View Controllers/Posts/PostRenderModel.swift

@@ -103,7 +103,10 @@ private func massageHTML(_ html: String, isIgnored: Bool, forumID: String) -> St
     document.removeEmptyEditedByParagraphs()
     document.addAttributeToBlueskyLinks()
     document.addAttributeToTweetLinks()
-    document.useHTML5VimeoPlayer()
+    let embedVideos = UserDefaults.standard.defaultingValue(for: Settings.embedVideos)
+    if embedVideos {
+        document.useHTML5VimeoPlayer()
+    }
     if let username = UserDefaults.standard.value(for: Settings.username) {
         document.identifyQuotesCitingUser(named: username, shouldHighlight: true)
         document.identifyMentionsOfUser(named: username, shouldHighlight: true)
@@ -118,7 +121,11 @@ private func massageHTML(_ html: String, isIgnored: Bool, forumID: String) -> St
     if (ForumTweaks(ForumID(forumID))?.magicCake) == true {
         document.addMagicCakeCSS()
     }
-    document.embedVideos()
+    if embedVideos {
+        document.embedVideos()
+    } else {
+        document.linkifyResidualVideoEmbeds()
+    }
     return document.bodyElement?.innerHTML ?? ""
 }
 

AwfulSettings/Sources/AwfulSettings/Settings.swift

@@ -62,6 +62,9 @@ public enum Settings {
     /// Turn each link to a tweet in a post into an embedded tweet.
     public static let embedTweets = Setting(key: "embed_tweets", default: true)
 
+    /// When `false`, leave video URLs as plain links instead of embedding YouTube, Vimeo, Imgur, etc. video players in posts.
+    public static let embedVideos = Setting(key: "embed_videos", default: true)
+
     /// Show custom titles for authors in the posts view (when it's wide enough).
     public static let enableCustomTitlePostLayout = Setting(key: "enable_custom_title_post_layout", default: false)
 

AwfulSettingsUI/Sources/AwfulSettingsUI/Localizable.xcstrings

@@ -99,6 +99,9 @@
     },
     "Embed Tweets" : {
 
+    },
+    "Embed Videos" : {
+
     },
     "Enable Custom Title Post Layout" : {
 
@@ -207,4 +210,4 @@
     }
   },
   "version" : "1.0"
-}
+}

AwfulSettingsUI/Sources/AwfulSettingsUI/SettingsView.swift

@@ -19,6 +19,7 @@ public struct SettingsView: View {
     @AppStorage(Settings.jumpToPostEndOnDoubleTap) private var doubleTapPostToJump
     @AppStorage(Settings.embedBlueskyPosts) private var embedBlueskyPosts
     @AppStorage(Settings.embedTweets) private var embedTweets
+    @AppStorage(Settings.embedVideos) private var embedVideos
     @AppStorage(Settings.enableHaptics) private var enableHaptics
     @AppStorage(Settings.fontScale) private var fontScale
     @AppStorage(Settings.frogAndGhostEnabled) private var frogAndGhostEnabled
@@ -151,6 +152,7 @@ public struct SettingsView: View {
                 Toggle("Always Animate GIFs", bundle: .module, isOn: $alwaysAnimateGIFs)
                 Toggle("Embed Bluesky Posts", bundle: .module, isOn: $embedBlueskyPosts)
                 Toggle("Embed Tweets", bundle: .module, isOn: $embedTweets)
+                Toggle("Embed Videos", bundle: .module, isOn: $embedVideos)
                 Toggle("Double-Tap Post to Jump", bundle: .module, isOn: $doubleTapPostToJump)
                 Toggle("Immersive Mode", bundle: .module, isOn: $immersiveModeEnabled)
                 Toggle("Enable Haptics", bundle: .module, isOn: $enableHaptics)