ci(account-contract): assert deployed==registered; harden workflow

Address codex review of the new account-contract CI:
- deploy script now throws (non-zero exit) if the deployed address does not
  match the AccountManager-registered address, instead of just logging it —
  so the smoke test actually fails CI when the invariant breaks.
- workflow fails fast if the local network never becomes ready.
- use `yarn install --frozen-lockfile` (verified in sync) to catch lock drift.

Author: critesjosh

.github/workflows/account-contract-tests.yml

@@ -57,15 +57,17 @@ jobs:
           for i in {1..30}; do
             if curl -s http://localhost:8080/status >/dev/null 2>&1; then
               echo "Local network is ready!"
-              break
+              exit 0
             fi
             echo "Waiting... ($i/30)"
             sleep 5
           done
+          echo "Local network failed to become ready in time" >&2
+          exit 1
 
       - name: Install project dependencies
         working-directory: account-contract
-        run: yarn install
+        run: yarn install --frozen-lockfile
 
       - name: Compile account contract and generate artifact
         working-directory: account-contract

account-contract/ts/deploy-account-contract.ts

@@ -54,7 +54,11 @@ const { contract: deployedAccountContract } = await deployMethod.send({
 
 console.log('PasswordAccount deployed at: ', deployedAccountContract.address.toString());
 console.log('Account registered at:       ', accountManager.address.toString());
-console.log(
-  'Deployed == registered:      ',
-  deployedAccountContract.address.equals(accountManager.address),
-);
+// The deployed contract IS the registered account (same secret key + salt), so the two must
+// match. Assert it (don't just log) so this doubles as a smoke test that fails loudly in CI.
+if (!deployedAccountContract.address.equals(accountManager.address)) {
+  throw new Error(
+    `Address mismatch: deployed ${deployedAccountContract.address.toString()} != registered ${accountManager.address.toString()}`,
+  );
+}
+console.log('Deployed == registered:       true');