feat: enhance error handling and path resolution in analyzer and installer modules

Author: CCA3370

src-tauri/src/analysis/analyzer.rs

@@ -96,29 +96,39 @@ impl Analyzer {
         Ok(staged_source.to_string_lossy().to_string())
     }
 
-    fn resolve_stable_source_path(&self, item: &DetectedItem) -> Option<String> {
-        if item.addon_type != AddonType::LuaScript {
+    fn canonicalize_existing_source_path(&self, source: &Path) -> Option<String> {
+        if !source.exists() {
             return None;
         }
 
+        source
+            .canonicalize()
+            .ok()
+            .map(|path| path.to_string_lossy().to_string())
+    }
+
+    fn resolve_stable_source_path(&self, item: &DetectedItem) -> Option<String> {
         let source = Path::new(&item.path);
-        if !source.is_file() || crate::archive_input::detect_archive_format(source).is_some() {
-            return None;
-        }
 
-        match self.stage_standalone_lua_source(source, &item.companion_paths) {
-            Ok(staged) => Some(staged),
-            Err(e) => {
-                logger::log_error(
-                    &format!(
-                        "Failed to stage standalone Lua source {:?}, continuing with original path: {}",
-                        source, e
-                    ),
-                    Some("analyzer"),
-                );
-                None
+        if item.addon_type == AddonType::LuaScript
+            && source.is_file()
+            && crate::archive_input::detect_archive_format(source).is_none()
+        {
+            match self.stage_standalone_lua_source(source, &item.companion_paths) {
+                Ok(staged) => return Some(staged),
+                Err(e) => {
+                    logger::log_error(
+                        &format!(
+                            "Failed to stage standalone Lua source {:?}, falling back to canonical source path: {}",
+                            source, e
+                        ),
+                        Some("analyzer"),
+                    );
+                }
             }
         }
+
+        self.canonicalize_existing_source_path(source)
     }
 
     /// Analyze a list of paths and return installation tasks

src-tauri/src/analysis/hash_collector.rs

@@ -31,7 +31,11 @@ impl HashCollector {
             return Ok(HashMap::new());
         }
 
-        let source = Path::new(&task.source_path);
+        let source = task
+            .resolved_source_path
+            .as_deref()
+            .map(Path::new)
+            .unwrap_or_else(|| Path::new(&task.source_path));
 
         if source.is_dir() {
             // Direct directory: compute SHA256 for all files

src-tauri/src/install/installer/handlers.rs

@@ -608,8 +608,8 @@ impl Installer {
         }
 
         Err(anyhow::anyhow!(
-            "Lua source path is neither file nor directory: {:?}",
-            source
+            "Source path is not a regular file or directory: {}",
+            source.display()
         ))
     }
 
@@ -764,7 +764,17 @@ impl Installer {
                 self.copy_single_file_with_progress(source, target, ctx)?;
             }
         } else {
-            return Err(anyhow::anyhow!("Source path is neither file nor directory"));
+            if !source.exists() {
+                return Err(anyhow::anyhow!(
+                    "Source file is no longer available: {}",
+                    source.display()
+                ));
+            }
+
+            return Err(anyhow::anyhow!(
+                "Source path is not a regular file or directory: {}",
+                source.display()
+            ));
         }
         Ok(())
     }

src-tauri/src/lib.rs

@@ -1571,6 +1571,12 @@ fn launch_xplane(xplane_path: String, args: Option<Vec<String>>) -> Result<(), S
                 // Return a structured error that frontend can handle
                 return Err(format!("ELEVATION_REQUIRED:{}", exe_path.display()));
             }
+            Err(e) if e.raw_os_error() == Some(193) => {
+                return Err(
+                    "Selected X-Plane executable is not a valid Windows executable. Check that the X-Plane path points to the real X-Plane installation."
+                        .to_string(),
+                );
+            }
             Err(e) => {
                 return Err(format!("Failed to launch X-Plane: {}", e));
             }
@@ -1599,7 +1605,14 @@ fn launch_xplane(xplane_path: String, args: Option<Vec<String>>) -> Result<(), S
         std::process::Command::new(exe_path)
             .args(&extra_args)
             .spawn()
-            .map_err(|e| format!("Failed to launch X-Plane: {}", e))?;
+            .map_err(|e| {
+                if e.raw_os_error() == Some(8) {
+                    "Selected X-Plane executable is not runnable on this system (Exec format error). Check that the X-Plane path points to the correct executable for your platform and that the file has execute permission."
+                        .to_string()
+                } else {
+                    format!("Failed to launch X-Plane: {}", e)
+                }
+            })?;
     }
 
     logger::log_info("X-Plane launched", Some("app"));