London | 26-ITP-May | Anita Amirhaeri | Sprint 1 | Form Controls#1246
London | 26-ITP-May | Anita Amirhaeri | Sprint 1 | Form Controls#1246anitahy73 wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
anitahy73
added
Needs Review
Luro91
added
the
Review in progress
| <form> | ||
|
|
||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name"><br> |
There was a problem hiding this comment.
How could you ensure that the name is at least 2 characters long?
| <input type="radio" id="colour-red" name="colour" value="red"> | ||
| Red | ||
| </label> | ||
|
|
||
| <label > | ||
| <input type="radio" id="colour-blue" name="colour" value="blue"> | ||
| Blue | ||
| </label> | ||
|
|
||
| <label > | ||
| <input type="radio" id="colour-green" name="colour" value="green"> | ||
| Green | ||
| </label> | ||
|
|
||
| </fieldset> | ||
|
|
||
| <label for="size">choose your size</label> | ||
|
|
||
|
|
||
| <select id="size"> | ||
| <option value="s">small</option> | ||
| <option value="m">medium</option> |
There was a problem hiding this comment.
How could you ensure that the user needs to choose a color and size?
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form> |
There was a problem hiding this comment.
The indentation of the child is not correct. How could you ensure consistent formatting of the code?
Luro91
added
Reviewed
anitahy73
added
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
anitahy73
added
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
2 participants
Learners, PR Template
Self checklist
Changelist
added the form as described in the task