Merge pull request #25 from DocumindHQ/validate-schema

Fix: Validate nested schema fields

Author: Tammilore

extractor/src/utils/schemaValidator.js

@@ -3,56 +3,62 @@
  * @param {Array} schema - The schema to validate.
  * @returns {Object} - { isValid: boolean, errors: Array<string> }
  */
+
 export function validateSchema(schema) {
-    const validTypes = ["string", "number", "array", "object", "boolean", "enum"];
-    let errors = [];
-  
-    if (!Array.isArray(schema)) {
-      errors.push("Schema must be an array.");
-      return { isValid: false, errors };
+  const validTypes = ["string", "number", "array", "object", "boolean", "enum"];
+  let errors = [];
+
+  if (!Array.isArray(schema)) {
+    errors.push("Schema must be an array.");
+    return { isValid: false, errors };
+  }
+
+  function validateField(field, path) {
+    if (!field.hasOwnProperty("name") || typeof field.name !== "string" || field.name.trim() === "") {
+      errors.push(`"name" is required and should be a non-empty string at ${path}`);
+    }
+
+    if (!field.hasOwnProperty("type") || !validTypes.includes(field.type)) {
+      errors.push(`"type" is required and must be one of ${validTypes.join(", ")} at ${path}`);
+    }
+
+    if (!field.hasOwnProperty("description") || typeof field.description !== "string" || field.description.trim() === "") {
+      errors.push(`"description" is required and should be a non-empty string at ${path}`);
     }
-  
-    function validateField(field, path) {
-      if (!field.hasOwnProperty("name") || typeof field.name !== "string" || field.name.trim() === "") {
-        errors.push(`"name" is required and should be a non-empty string at ${path}`);
-      }
-  
-      if (!field.hasOwnProperty("type") || !validTypes.includes(field.type)) {
-        errors.push(`"type" is required and must be one of ${validTypes.join(", ")} at ${path}`);
-      }
-  
-      if (!field.hasOwnProperty("description") || typeof field.description !== "string" || field.description.trim() === "") {
-        errors.push(`"description" is required and should be a non-empty string at ${path}`);
-      }
-  
-      // Additional checks for arrays
-      if (field.type === "array") {
-        if (!field.hasOwnProperty("children")) {
-          errors.push(`"children" property is required for arrays at ${path}`);
-        } else if (!Array.isArray(field.children) || field.children.length === 0) {
-          errors.push(`"children" must be a non-empty array at ${path}`);
-        } else {
-          // Recursively validate each child
-          field.children.forEach((child, index) => validateField(child, `${path}.children[${index}]`));
-        }
-      }
 
-      // Additional checks for enum
     if (field.type === "enum") {
       if (!field.hasOwnProperty("values") || !Array.isArray(field.values) || field.values.length === 0) {
-        errors.push(`"values" is required and must be a non-empty array for enum at ${path}`);
+        errors.push(`"values" is required and must be a non-empty array for enum "${field.name}" at ${path}`);
       } else if (!field.values.every((value) => typeof value === "string")) {
-        errors.push(`"values" for enum at ${path} must be an array of strings`);
+        errors.push(`"values" for enum "${field.name}" at ${path} must be an array of strings`);
       }
     }
 
+    if (field.type === "array") {
+      if (!field.hasOwnProperty("children")) {
+        errors.push(`"children" property is required for array "${field.name}" at ${path}`);
+      } else if (!Array.isArray(field.children) || field.children.length === 0) {
+        errors.push(`"children" must be a non-empty array for "${field.name}" at ${path}`);
+      } else {
+        field.children.forEach((child, index) => validateField(child, `${path}.children[${index}]`));
+      }
+    }
+
+    if (field.type === "object") {
+      if (!field.hasOwnProperty("children")) {
+        errors.push(`"children" property is required for object "${field.name}" at ${path}`);
+      } else if (!Array.isArray(field.children) || field.children.length === 0) {
+        errors.push(`"children" must be a non-empty array for "${field.name}" at ${path}`);
+      } else {
+        field.children.forEach((child, index) => validateField(child, `${path}.children[${index}]`));
+      }
+    }
   }
-  
-    schema.forEach((field, index) => validateField(field, `schema[${index}]`));
-  
-    return {
-      isValid: errors.length === 0,
-      errors,
-    };
-  }
-  
+
+  schema.forEach((field, index) => validateField(field, `schema[${index}]`));
+
+  return {
+    isValid: errors.length === 0,
+    errors,
+  };
+}