Renamed UnhandledDestinationException to UnhandledNavigationException. (#402)

Author: EranBoudjnah

app/src/androidTest/java/com/mitteloupe/whoami/test/HistoryTest.kt

@@ -79,9 +79,11 @@ class HistoryTest : BaseTest() {
     @LocalStore(
         localStoreDataIds = [KEY_VALUE_NO_HISTORY]
     )
-    fun givenNoHistoryWhenOnHistoryScreenThenSeesHistory() {
+    fun givenNoHistoryWhenOnHistoryScreenThenSeesNoRecords() {
         with(historyScreen) {
-            seeNoRecordsLabel()
+            retry(repeat = 20) {
+                seeNoRecordsLabel()
+            }
         }
     }
 

app/src/main/java/com/mitteloupe/whoami/navigation/mapper/HistoryNavigationEventDestinationMapper.kt

@@ -2,7 +2,7 @@ package com.mitteloupe.whoami.navigation.mapper
 
 import com.mitteloupe.whoami.architecture.presentation.navigation.PresentationNavigationEvent
 import com.mitteloupe.whoami.architecture.presentation.navigation.PresentationNavigationEvent.Back
-import com.mitteloupe.whoami.architecture.ui.navigation.exception.UnhandledDestinationException
+import com.mitteloupe.whoami.architecture.ui.navigation.exception.UnhandledNavigationException
 import com.mitteloupe.whoami.architecture.ui.navigation.mapper.NavigationEventDestinationMapper
 import com.mitteloupe.whoami.architecture.ui.navigation.model.UiDestination
 
@@ -13,7 +13,7 @@ class HistoryNavigationEventDestinationMapper :
     override fun mapTypedEvent(navigationEvent: PresentationNavigationEvent): UiDestination =
         when (navigationEvent) {
             is Back -> backUiDestination()
-            else -> throw UnhandledDestinationException(navigationEvent)
+            else -> throw UnhandledNavigationException(navigationEvent)
         }
 
     private fun backUiDestination() = UiDestination { navController ->

app/src/test/java/com/mitteloupe/whoami/navigation/mapper/HomeNavigationEventDestinationMapperTest.kt

@@ -6,7 +6,7 @@ import androidx.navigation.NavController
 import com.google.android.gms.oss.licenses.OssLicensesMenuActivity
 import com.mitteloupe.whoami.analytics.Analytics
 import com.mitteloupe.whoami.architecture.presentation.navigation.PresentationNavigationEvent
-import com.mitteloupe.whoami.architecture.ui.navigation.exception.UnhandledDestinationException
+import com.mitteloupe.whoami.architecture.ui.navigation.exception.UnhandledNavigationException
 import com.mitteloupe.whoami.home.presentation.navigation.HomePresentationNavigationEvent.OnSavedDetails
 import com.mitteloupe.whoami.home.presentation.navigation.HomePresentationNavigationEvent.OnViewHistory
 import com.mitteloupe.whoami.home.presentation.navigation.HomePresentationNavigationEvent.OnViewOpenSourceNotices
@@ -115,12 +115,12 @@ class HomeNavigationEventDestinationMapperTest {
         val actualException = requireNotNull(caughtException)
         assertThat(
             actualException,
-            isA(UnhandledDestinationException::class.java)
+            isA(UnhandledNavigationException::class.java)
         )
         assertThat(
             actualException.message,
             matchesPattern(
-                "^Navigation to PresentationNavigationEvent\\\$MockitoMock\\\$\\w+ " +
+                "^Navigation event PresentationNavigationEvent\\\$MockitoMock\\\$\\w+ " +
                     "was not handled.$"
             )
         )

…ception/UnhandledDestinationException.kt …xception/UnhandledNavigationException.ktarchitecture/ui/src/main/java/com/mitteloupe/whoami/architecture/ui/navigation/exception/UnhandledDestinationException.kt renamed to architecture/ui/src/main/java/com/mitteloupe/whoami/architecture/ui/navigation/exception/UnhandledNavigationException.kt architecture/ui/src/main/java/com/mitteloupe/whoami/architecture/ui/navigation/exception/UnhandledDestinationException.kt renamed to architecture/ui/src/main/java/com/mitteloupe/whoami/architecture/ui/navigation/exception/UnhandledNavigationException.kt

@@ -2,7 +2,7 @@ package com.mitteloupe.whoami.architecture.ui.navigation.exception
 
 import com.mitteloupe.whoami.architecture.presentation.navigation.PresentationNavigationEvent
 
-class UnhandledDestinationException(destination: PresentationNavigationEvent) :
+class UnhandledNavigationException(event: PresentationNavigationEvent) :
     IllegalArgumentException(
-        "Navigation to ${destination::class.simpleName} was not handled."
+        "Navigation event ${event::class.simpleName} was not handled."
     )

architecture/ui/src/main/java/com/mitteloupe/whoami/architecture/ui/navigation/mapper/NavigationEventDestinationMapper.kt

@@ -1,7 +1,7 @@
 package com.mitteloupe.whoami.architecture.ui.navigation.mapper
 
 import com.mitteloupe.whoami.architecture.presentation.navigation.PresentationNavigationEvent
-import com.mitteloupe.whoami.architecture.ui.navigation.exception.UnhandledDestinationException
+import com.mitteloupe.whoami.architecture.ui.navigation.exception.UnhandledNavigationException
 import com.mitteloupe.whoami.architecture.ui.navigation.model.UiDestination
 import kotlin.reflect.KClass
 
@@ -15,7 +15,7 @@ abstract class NavigationEventDestinationMapper<in EVENT : PresentationNavigatio
         }
 
         else -> {
-            mapGenericEvent(navigationEvent) ?: throw UnhandledDestinationException(
+            mapGenericEvent(navigationEvent) ?: throw UnhandledNavigationException(
                 navigationEvent
             )
         }