Removed forced ktlint version. Suppressed some detekt errors.

Author: EranBoudjnah

app/build.gradle.kts

@@ -89,7 +89,6 @@ android {
 }
 
 ktlint {
-    version.set("0.50.0")
     android.set(true)
 }
 

app/src/main/java/com/mitteloupe/whoami/di/HistoryModule.kt

@@ -22,6 +22,7 @@ import dagger.hilt.components.SingletonComponent
 
 @Module
 @InstallIn(SingletonComponent::class)
+@Suppress("TooManyFunctions")
 object HistoryModule {
     @Provides
     fun providesSavedIpAddressRecordDomainMapper() = SavedIpAddressRecordDomainMapper()

app/src/main/java/com/mitteloupe/whoami/di/HomeModule.kt

@@ -42,6 +42,7 @@ object HomeModule {
     fun providesExceptionPresentationMapper() = ExceptionPresentationMapper()
 
     @Provides
+    @Suppress("LongParameterList")
     fun providesHomeViewModel(
         getConnectionDetailsUseCase: GetConnectionDetailsUseCase,
         connectionDetailsPresentationMapper: ConnectionDetailsPresentationMapper,

app/src/main/java/com/mitteloupe/whoami/di/HomeUiModule.kt

@@ -47,6 +47,7 @@ object HomeUiModule {
     fun providesConnectionDetailsUiMapper() = ConnectionDetailsUiMapper()
 
     @Provides
+    @Suppress("LongParameterList")
     fun providesHomeDependencies(
         homeViewModel: HomeViewModel,
         homeViewStateUiMapper: HomeViewStateUiMapper,

architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/idlingresource/AppNotRespondingHandler.kt

@@ -43,7 +43,7 @@ private fun UiDevice.closeAnrWithWait(appNotRespondingDialog: UiObject) {
         val dialogText = appNotRespondingDialog.text
         val appName = dialogText.take(dialogText.length - APP_NOT_RESPONDING_TEXT.length)
         Log.i(APP_NOT_RESPONDING_TAG, "App \"$appName\" is not responding. Pressed on wait.")
-    } catch (uiObjectNotFoundException: UiObjectNotFoundException) {
+    } catch (_: UiObjectNotFoundException) {
         Log.i(APP_NOT_RESPONDING_TAG, "Detected app not responding dialog, but window disappeared.")
     }
 }

architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/server/MockDispatcher.kt

@@ -15,7 +15,7 @@ class MockDispatcher :
     ResponseBinder {
     override var testName: String = ""
 
-    override val usedEndpoints: Set<MockRequest>
+    final override val usedEndpoints: Set<MockRequest>
         field = mutableSetOf()
 
     private val responses = mutableMapOf<MockRequest, MockResponseFactory>()

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/history/mapper/NewIpAddressRecordLocalMapperTest.kt

@@ -51,6 +51,7 @@ class NewIpAddressRecordLocalMapperTest(
             )
         )
 
+        @Suppress("LongParameterList")
         private fun testCase(
             testTitle: String,
             ipAddress: String,

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/history/mapper/SavedIpAddressRecordDataMapperTest.kt

@@ -48,6 +48,7 @@ class SavedIpAddressRecordDataMapperTest(
             )
         )
 
+        @Suppress("LongParameterList")
         private fun testCase(
             testTitle: String,
             ipAddress: String,

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/ipaddressinformation/mapper/IpAddressInformationDataMapperTest.kt

@@ -38,6 +38,7 @@ class IpAddressInformationDataMapperTest(
             )
         )
 
+        @Suppress("LongParameterList")
         private fun testCase(
             city: String?,
             region: String?,

history/data/src/test/java/com/mitteloupe/whoami/history/data/mapper/SavedIpAddressRecordDomainMapperTest.kt

@@ -45,6 +45,7 @@ class SavedIpAddressRecordDomainMapperTest(
             )
         )
 
+        @Suppress("LongParameterList")
         private fun testCase(
             testTitle: String,
             ipAddress: String,