Tidied up WebServerRule.

Author: EranBoudjnah

architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/rule/WebServerRule.kt

@@ -12,54 +12,48 @@ class WebServerRule(
     private val lazyResponseStore: Lazy<ResponseStore>
 ) : TestRule {
     override fun apply(base: Statement, description: Description): Statement =
-        WebServerInitializationStatement(
-            lazyMockDispatcher,
-            lazyResponseStore,
-            base,
-            description
-        )
-
-    private class WebServerInitializationStatement(
-        private val lazyMockDispatcher: Lazy<ResponseBinder>,
-        private val lazyResponseStore: Lazy<ResponseStore>,
-        private val base: Statement,
-        private val description: Description
-    ) : Statement() {
-        val responseStore by lazy { lazyResponseStore.value }
-        val mockDispatcher by lazy { lazyMockDispatcher.value }
+        WebServerStatement(lazyMockDispatcher, lazyResponseStore, base, description)
+}
 
-        override fun evaluate() {
-            val requestResponses = description.requestResponseIds()
-                .map { requestResponseId ->
+private class WebServerStatement(
+    private val lazyMockDispatcher: Lazy<ResponseBinder>,
+    private val lazyResponseStore: Lazy<ResponseStore>,
+    private val base: Statement,
+    private val description: Description
+) : Statement() {
+    val responseStore by lazy { lazyResponseStore.value }
+    val mockDispatcher by lazy { lazyMockDispatcher.value }
+
+    override fun evaluate() {
+        val requestResponses = description.requestResponseIds()
+            .map { requestResponseId ->
+                requireNotNull(
                     responseStore.responseFactories[requestResponseId]
-                        ?: throw IllegalArgumentException(
-                            "Request/Response ID $requestResponseId not found."
-                        )
-                }
-
-            mockDispatcher.testName = description.displayName
-            requestResponses.forEach { requestResponse ->
-                mockDispatcher.bindResponse(requestResponse)
+                ) { "Request/Response ID $requestResponseId not found." }
             }
-            val stubbedResponseKeys = requestResponses
-                .map { requestResponse -> requestResponse.request }
-                .toSet()
 
-            base.evaluate()
+        mockDispatcher.testName = description.displayName
+        requestResponses.forEach { requestResponse ->
+            mockDispatcher.bindResponse(requestResponse)
+        }
+        val stubbedResponseKeys = requestResponses
+            .map { requestResponse -> requestResponse.request }
+            .toSet()
 
-            val usedResponseKeys = mockDispatcher.usedEndpoints.toSet()
+        base.evaluate()
 
-            val unusedResponseKeys = stubbedResponseKeys - usedResponseKeys
-            check(unusedResponseKeys.isEmpty()) {
-                "${unusedResponseKeys.size} unused stubbed URLs:\n[" +
-                    unusedResponseKeys.joinToString("]\n[") + "]"
-            }
+        val usedResponseKeys = mockDispatcher.usedEndpoints.toSet()
 
-            mockDispatcher.reset()
+        val unusedResponseKeys = stubbedResponseKeys - usedResponseKeys
+        check(unusedResponseKeys.isEmpty()) {
+            "${unusedResponseKeys.size} unused stubbed URLs:\n[" +
+                unusedResponseKeys.joinToString("]\n[") + "]"
         }
 
-        private fun Description.requestResponseIds() =
-            annotations.filterIsInstance<ServerRequestResponse>()
-                .flatMap { serverResponse -> serverResponse.requestResponseIds.toList() }
+        mockDispatcher.reset()
     }
+
+    private fun Description.requestResponseIds() =
+        annotations.filterIsInstance<ServerRequestResponse>()
+            .flatMap { serverResponse -> serverResponse.requestResponseIds.toList() }
 }