Skip to content

Commit 4375a1f

Browse files
authored
Removal coinbase support (#36)
* remove coinbasepro-python dependencies * update README * Remove coinbase retriever * bump to 0.2.0dev * fix doc * fix docs
1 parent 1da70d4 commit 4375a1f

9 files changed

Lines changed: 12 additions & 113 deletions

File tree

CryptoPrice/__about__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
__version__ = "0.1.3"
2-
__author__ = "EtWnn"
1+
__version__ = "0.2.0dev"
2+
__author__ = "EtWnn"

CryptoPrice/__init__.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,15 @@
22

33
from CryptoPrice.retrievers.BinanceRetriever import BinanceRetriever
44
from CryptoPrice.retrievers.KucoinRetriever import KucoinRetriever
5-
from CryptoPrice.retrievers.CoinbaseRetriever import CoinbaseRetriever
65
from CryptoPrice.retrievers.MetaRetriever import MetaRetriever
76

87

98
def get_default_retriever() -> MetaRetriever:
109
"""
11-
Provides a hands on price retriever made from the default BinanceRetriever, the default KucoinRetriever
12-
and the default CoinbaseRetriever
10+
Provides a hands on price retriever made from the default BinanceRetriever and the default KucoinRetriever
11+
1312
1413
:return: the meta retriever constructed
1514
:rtype: MetaRetriever
1615
"""
17-
return MetaRetriever([BinanceRetriever(), KucoinRetriever(), CoinbaseRetriever()])
16+
return MetaRetriever([BinanceRetriever(), KucoinRetriever()])

CryptoPrice/retrievers/CoinbaseRetriever.py

Lines changed: 0 additions & 87 deletions
This file was deleted.

README.rst

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
===============================
2-
Welcome to CryptoPrice 0.1.3
2+
Welcome to CryptoPrice 0.2.0dev
33
===============================
44

55

@@ -26,7 +26,6 @@ amount of different tokens or to compare the price difference between exchanges.
2626
It currently includes:
2727
- Binance API
2828
- Kucoin API
29-
- Coinbase API
3029
- Cross-API logic
3130

3231
Quick Tour
@@ -38,10 +37,8 @@ Quick Tour
3837

3938
.. code:: bash
4039
41-
pip install --no-deps python-CryptoPrice
4240
pip install python-CryptoPrice
4341
44-
*Note*: `--no-deps` is needed as one of the dependencies is not hosted one PYPI, simply on git.
4542
4643
You can also install the latest developments (not stable):
4744

@@ -95,7 +92,7 @@ than the one above as several API calls (or database requests) may be needed.
9592
9693
.. code-block:: bash
9794
98-
>>LTC = 420.76841 XRP, source: {'binance', 'kucoin', 'coinbase'}
95+
>>LTC = 420.76841 XRP, source: {'binance', 'kucoin'}
9996
10097
10198
Donation

docs/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
# The full version, including alpha/beta/rc tags
2525
this_directory = os.path.abspath(os.path.dirname(__file__))
2626
about = {}
27-
with open(os.path.join(this_directory, f'../../{project}/__init__.py'), encoding='utf-8') as f:
27+
with open(os.path.join(this_directory, f'../../{project}/__about__.py'), encoding='utf-8') as f:
2828
exec(f.read(), about)
2929
release = about['__version__']
3030

docs/source/overview.rst

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,8 @@ Installation
88

99
.. code:: bash
1010
11-
pip install --no-deps python-CryptoPrice
1211
pip install python-CryptoPrice
1312
14-
*Note*: `--no-deps` is needed as one of the dependencies is not hosted one PYPI, simply on git.
15-
1613
You can also install the latest developments (not stable):
1714

1815
.. code:: bash
@@ -29,7 +26,7 @@ Get a retriever
2926
---------------
3027

3128
To fetch some prices, you will need to use a retriever, there are several kinds and instances of retrievers in this
32-
library so we made a default one for you:
29+
library so a default one is ready for you:
3330

3431
.. code:: python
3532
@@ -85,4 +82,4 @@ than the one above as several API calls (or database requests) have to be made.
8582
8683
.. code-block:: bash
8784
88-
>>LTC = 420.76841 XRP, source: {'binance', 'kucoin', 'coinbase'}
85+
>>LTC = 420.76841 XRP, source: {'binance', 'kucoin'}

docs/source/retrievers.rst

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@ Implemented Retrievers
3131

3232
Below are the retrievers implemented in this library.
3333

34-
.. automodule:: CryptoPrice.retrievers.CoinbaseRetriever
35-
:special-members: __init__
36-
:members:
37-
:undoc-members:
38-
3934
.. automodule:: CryptoPrice.retrievers.BinanceRetriever
4035
:special-members: __init__
4136
:members:

requirements.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@ appdirs
33
sphinx
44
sphinx_rtd_theme
55
python-binance
6-
kucoin-python
7-
git+https://github.com/teleprint-me/coinbasepro-python.git@2.1.28#egg=cbpro
6+
kucoin-python

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
install_requires=['requests',
2929
'appdirs',
3030
'python-binance',
31-
'kucoin-python',
32-
'cbpro@git+https://github.com/teleprint-me/coinbasepro-python.git@2.1.28'],
31+
'kucoin-python'],
3332
keywords='eth bsc price ohlc candle history API Binance Kucoin',
3433
classifiers=[
3534
'Intended Audience :: Developers',

0 commit comments

Comments
 (0)