fix(gui): prevent crash on right-click in Project Explorer with no selection#510
Open
bhavyabhardwaj001 wants to merge 2 commits into
Open
fix(gui): prevent crash on right-click in Project Explorer with no selection#510bhavyabhardwaj001 wants to merge 2 commits into
bhavyabhardwaj001 wants to merge 2 commits into
Conversation
…on in Project Explorer Replaced selectedIndexes()-based logic with indexAt(position) to correctly handle right-click events. - Prevents crash when no item is selected - Ensures only valid indexes are used - Aligns behavior with expected context menu interaction - Ensures level is always defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #509
Purpose
The Project Explorer context menu crashes when a user right-clicks without selecting any item. This happens because the current implementation relies on
selectedIndexes()and assumes that a selection is always present.Approach
selectedIndexes()withindexAt(position)to determine the item under the cursorindex.isValid()check to safely handle right-clicks on empty areastemp_index) to safely traverse parent hierarchy and compute levelChanges Made
openMenu()implementation inProjectExplorer.pyindexes[0]levelis always initialized before useImpact
Verification