address: PyCharm linter warnings

Author: ericwang401

pyproject.toml

@@ -16,6 +16,7 @@ dependencies = [
     "pandas>=2.0",
     "rich>=14.3.3",
     "questionary>=2.0",
+    "prompt_toolkit>=3.0",
     "mcculw>=1.0.0",
     "pyobjc-framework-quartz>=10; sys_platform == 'darwin'",
 ]

src/mid_det/ratings/__main__.py

@@ -29,7 +29,7 @@
 from mid_det import recorder, session
 from mid_det.ratings import core as rcore
 from mid_det.ratings import display as rdisplay
-from mid_det.ratings.wizard import run_ratings_wizard
+from mid_det.ratings.setup_wizard import run_ratings_wizard
 
 _PACKAGE_DIR = Path(__file__).resolve().parent          # src/mid_det/ratings/
 _PROJECT_ROOT = _PACKAGE_DIR.parent.parent.parent        # project root

src/mid_det/ratings/wizard.py src/mid_det/ratings/setup_wizard.pysrc/mid_det/ratings/wizard.py renamed to src/mid_det/ratings/setup_wizard.py

@@ -51,7 +51,7 @@ def run_ratings_wizard() -> tuple[str, bool, str]:
     ).ask()
     if subject_id is None:
         _quit()
-    subject_id = subject_id.strip() or _SUBJECT_PLACEHOLDER
+    subject_id: str = subject_id.strip() or _SUBJECT_PLACEHOLDER
 
     show_instructions: bool | None = questionary.confirm(
         "Show instructions?", default=True, style=_QSTYLE

src/mid_det/recorder.py

@@ -274,7 +274,7 @@ def append(self, record: TrialRecord) -> None:
         # MATLAB rt_vector: -2 = early press, -1 = miss/too-slow, else RT (seconds).
         if record.early_press:
             rt: float = -2
-        elif record.rt_ms == "":
+        elif isinstance(record.rt_ms, str):  # "" sentinel = miss/too-slow
             rt = -1
         else:
             rt = record.rt_ms / 1000

src/mid_det/setup_wizard.py

@@ -100,13 +100,13 @@ def prompt_legacy_name(legacy_dir: Path, filename_for: Callable[[str], str]) ->
 
     # Bottom toolbar: live preview of the resolved path as NAME is typed.
     def _toolbar():
-        name = get_app().current_buffer.text.strip()
-        if not name:
+        typed = get_app().current_buffer.text.strip()
+        if not typed:
             return FormattedText(
                 [("fg:ansired bold", " ✗  Name cannot be empty")]
             )
-        target = legacy_dir / filename_for(name)
-        return FormattedText([("fg:ansigreen bold", f" → saves as {target}")])
+        preview = legacy_dir / filename_for(typed)
+        return FormattedText([("fg:ansigreen bold", f" → saves as {preview}")])
 
     while True:
         raw = ""
@@ -119,7 +119,6 @@ def _toolbar():
             )
         except (KeyboardInterrupt, EOFError):
             _quit()
-            raise  # unreachable; tells PyCharm this branch never continues
         name = raw.strip()
         if not name:
             _rcon.print("[red]Name cannot be empty.[/red]")
@@ -136,10 +135,12 @@ def _toolbar():
         ).ask()
         if overwrite is None:
             _quit()
-            raise  # unreachable; tells PyCharm this branch never continues
         if overwrite:
             return name
         # else: loop and re-prompt for a different NAME
+    # Unreachable: the loop only exits via `return` or `_quit()`. Present so the
+    # type checker can see every path returns `str` (not `str | None`).
+    raise AssertionError("prompt_legacy_name loop exited unexpectedly")
 
 
 # ── Custom RT field ───────────────────────────────────────────────────────────