Notifications filter: full-page reload + diagnostic logs

The pushState approach didn't stick in the CI screenshot — the URL
still reported as no-query and the dropdown stayed on "All types".
Likely an interaction with Discourse's location service. Falling
back to window.location.assign(newUrl) does an unconditional full
navigation; on reload, model() reads the fresh ?type= from
window.location and the filtered list renders. Slightly heavier UX
but bulletproof for the click case.

For the still-failing direct-URL cases (tests 2 & 3), the failure
screenshots show TYPE = "new reply" (so selectedValue does read the
URL) yet both Liked and Replied rows remain visible — the server
didn't filter. Added one-line warn logs at the model() boundary and
at the controller patch's index branch so the next CI cycle prints
exactly what the route built and what the server received. Will
remove once the cause is pinned down.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017kMMnEotb32Equr761bQkf

Author: Shalom-Karr

assets/javascripts/discourse/components/notifications-type-filter.gjs

@@ -73,29 +73,29 @@ export default class NotificationsTypeFilter extends Component {
   }
 
   @action
-  async onChange(value) {
+  onChange(value) {
     // `router.transitionTo(path + ?type=...)` is a NO-OP here because
     // Ember treats the new URL as the same route — `type` isn't declared
     // as a controller queryParam (an Ember classic-reopen limitation
     // noted at length in the initializer), so the queryParam diff is
     // empty and the transition silently aborts WITHOUT touching the
-    // URL. Confirmed via the failing system spec: the URL stayed at the
-    // original path after picking a type from the dropdown.
+    // URL. A pushState+router.refresh dance had a similar problem —
+    // the Capybara assertion saw the URL revert.
     //
-    // `window.history.pushState` bypasses Ember's router entirely and
-    // updates the address-bar URL unconditionally. `router.refresh()`
-    // then re-runs the route's model(), which reads `?type=...` straight
-    // from window.location — so the list re-fetches with the new
-    // filter. Same shape on the way back to All (the `type` key is
-    // removed first).
+    // Falling back to a full navigation via `window.location.assign`
+    // sidesteps the whole Ember queryParam dance. The page reloads,
+    // route model() reads the fresh `?type=` from window.location, and
+    // the filtered list renders. Slightly heavier than an in-app
+    // transition, but the alternative is reaching into Discourse's
+    // queryParam plumbing — and the filter pick happens infrequently
+    // enough that a single reload is a fine UX trade.
     const url = new URL(window.location.href);
     if (value === ALL) {
       url.searchParams.delete("type");
     } else {
       url.searchParams.set("type", value);
     }
-    window.history.pushState({}, "", url.pathname + url.search);
-    await this.router.refresh();
+    window.location.assign(url.pathname + url.search);
   }
 
   <template>

assets/javascripts/discourse/initializers/notifications-type-filter.js

@@ -58,12 +58,21 @@ export default {
             this.get("currentUser.username") !== username &&
             !this.get("currentUser.admin")
           ) {
+            // eslint-disable-next-line no-console
+            console.warn("[notif-filter] early exit: not own profile or admin");
             return;
           }
           const args = { username, filter: params.filter, limit: 60 };
           const urlType = new URLSearchParams(window.location.search).get(
             "type"
           );
+          // eslint-disable-next-line no-console
+          console.warn(
+            "[notif-filter] model() — urlType=",
+            urlType,
+            "location=",
+            window.location.href
+          );
           if (urlType && urlType !== "all") {
             if (urlType === "mod_notes") {
               // Staff-only path — server patch handles routing into a
@@ -76,6 +85,8 @@ export default {
               args.filter_by_types = urlType.toLowerCase();
             }
           }
+          // eslint-disable-next-line no-console
+          console.warn("[notif-filter] store.find args=", JSON.stringify(args));
           return this.store.find("notification", args);
         },
       });

sub_plugins/mod_categories.rb

@@ -1408,6 +1408,10 @@ def index
           # core controller a value it recognizes.
           canonical_type =
             ::Notification.types.keys.find { |k| k.to_s.casecmp(requested_type).zero? }
+          ::Rails.logger.warn(
+            "[notif-filter] NotificationsController#index requested_type=#{requested_type.inspect} " \
+              "canonical=#{canonical_type.inspect} filter_by_types(before)=#{params[:filter_by_types].inspect}",
+          )
           params[:filter_by_types] = canonical_type.to_s if canonical_type
           params.delete(:type)
           super