Delete unused highlightLint field from PerseusCategorizerWidgetOptions#3690
Merged
Conversation
Contributor
|
Size Change: -25 B (0%) Total Size: 508 kB 📦 View Changed
ℹ️ View Unchanged
|
benchristel
commented
May 29, 2026
| values: number[]; | ||
| /** Whether we should highlight i18n linter errors found on this widget */ | ||
| // TODO(benchristel): highlightLint doesn't seem to be used. Delete it. | ||
| highlightLint?: boolean; |
Member
Author
There was a problem hiding this comment.
@ivyolamit heads up since you mentioned you and Earl will be doing the next release. There's some test data in webapp that still includes highlightLint: false — you might need to update that if there are type errors.
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (0f5b307) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3690If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3690If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3690 |
SonicScrewdriver
approved these changes
Jun 8, 2026
An error occurred while trying to automatically change base from
benc/remove-deprecated-fields
to
main
June 8, 2026 22:16
…izerWidgetOptions
… property has been removed from the PerseusCategorizerWidgetOptions type. Callers should not pass this property.
benchristel
force-pushed
the
benc/delete-highlightLint
branch
from
4a1707f to
0f5b307
Compare
github-actions
Bot
added
item-splitting-change
schema-change
benchristel
added
item-splitting-change-ack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: none
Test plan:
CI checks should pass.