Add a time-dependent function for CO2 (Update PR #1173)#1457
Open
jihyeonjang wants to merge 4 commits into
Open
Add a time-dependent function for CO2 (Update PR #1173)#1457jihyeonjang wants to merge 4 commits into
jihyeonjang wants to merge 4 commits into
Conversation
This commit was modified from PR MPAS-Dev#1173 by weiwangncar for making a function of year (time) for co2 concentration, following what's done in WRFv4.2. This commit moves shared longwave and shortwave radiation subroutines or functions into a new utility module (mpas_atmphys_radiation_utils). Subroutines and functions needed to compute constants or arrays for longwave and shortwave schemes are moved in this module. In particular, the co2 estimate function has been moved there.
dudhia
approved these changes
May 22, 2026
Contributor
|
@jihyeonjang Creating a separate module for radiation utility is good. I would prefer to have CO2 computed from a different routine than radconst. This will keep radconst the same as in WRF, and later when a table version of CO2 is added, no change would be required to modify radconst. But I'm ok if you and Michael are ok with the current solution. |
Collaborator
|
I had similar thoughts to Wei as CO2 and radconst are not physically related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #1173, which proposed a smoothly increasing, time-dependent CO2 concentration function. The function form is a close fit for past CO2 growth and extrapolates it for the future.
This update introduces a new radiation utility module for subroutines or functions used by both LW and SW radiation schemes.
Summary of changes:
mpas_atmphys_radiation_utils.F)radconstandco2_estimateintompas_atmphys_radiation_utilsco2toco2_valto avoid conflict with the non-1Dco2array used by the CAM radiation schemeco2_valinradconstradconstbeforerrtmg_lwradandrrtmg_swrad(Moving
radconstfrommpas_atmphys_driver_radiation_sw.F90tompas_atmphys_radiation_utils.F90removes the build dependency of LW on the SW module.)A future update will implement reading GHG values from prescribed tables, following the WRF approach. The table year-dependent GHG is based on observed values for past years and official climate scenarios for future years.