Skip to content

Commit c1ea3f5

Browse files
committed
fixed the apply-page select preset dropdown
1 parent c7d34e1 commit c1ea3f5

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

RosettaX/pages/p04_calibrate/sections/s02_calibration_picker/callbacks.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
CUSTOM_PRESET_NAME,
1111
build_scattering_target_model_preset_options,
1212
get_calibration_standard_parameters,
13-
get_scattering_target_model_preset,
1413
parse_optical_geometry_from_calibration_standard_parameters,
1514
resolve_scattering_target_model_preset,
1615
)
@@ -69,7 +68,7 @@ def _register_target_model_preset_runtime_sync_callback(self) -> None:
6968
)
7069
def sync_target_model_preset_from_runtime_config(
7170
runtime_config_data: Any,
72-
) -> str:
71+
) -> Optional[str]:
7372
runtime_config = RuntimeConfig.from_dict(
7473
runtime_config_data if isinstance(runtime_config_data, dict) else None
7574
)
@@ -82,22 +81,18 @@ def sync_target_model_preset_from_runtime_config(
8281
available_values = {
8382
option.get("value")
8483
for option in build_scattering_target_model_preset_options(
85-
include_empty_option=True,
86-
empty_label="Select",
8784
)
8885
if isinstance(option, dict)
8986
}
9087

9188
if configured_value in available_values:
9289
return configured_value
9390

94-
return get_scattering_target_model_preset(
95-
configured_value,
96-
).name
91+
return ""
9792

9893
def _register_target_model_details_visibility_callback(self) -> None:
9994
"""
100-
Show target model detail boxes only after a preset is selected.
95+
Show target model detail boxes only for the custom preset.
10196
"""
10297

10398
@dash.callback(
@@ -118,12 +113,10 @@ def _register_target_model_details_visibility_callback(self) -> None:
118113
def toggle_target_model_detail_boxes(
119114
target_model_preset: Any,
120115
) -> tuple[dict[str, str], dict[str, str]]:
121-
has_selected_preset = services.has_selected_target_model_preset(
122-
target_model_preset,
123-
)
116+
is_custom_preset = str(target_model_preset or "").strip() == CUSTOM_PRESET_NAME
124117

125118
visible_style = services.build_scattering_target_model_container_style(
126-
is_visible=has_selected_preset,
119+
is_visible=is_custom_preset,
127120
)
128121

129122
return visible_style, dict(visible_style)

tests/application/page_regressions_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def test_layout_uses_model_panels_without_target_particle_model_wrapper(
250250
assert "Model parameters" in text_nodes
251251
assert "Target Mie relation preview" in text_nodes
252252

253-
def test_layout_starts_with_select_placeholder_and_hidden_target_model_boxes(
253+
def test_layout_starts_with_custom_preset_and_hidden_target_model_boxes(
254254
self,
255255
monkeypatch,
256256
) -> None:

0 commit comments

Comments
 (0)