Skip to content

Commit 4e33368

Browse files
Temporarily disable latest pulp and mcore until we fix its nvidia-resiliency-ext dependency (#1285)
- `megatron-core==0.17.0` released yesterday which requires nightly version of `nvidia-resiliency-ext` for an import. Pre-installed version in DLFW Pytorch container is `nvidia-resiliency-ext==0.5.0` - Temporarily pin `mcore<0.17.0` to unblock PR from merging. - Pin `pulp<4.0` as it has some breaking changes and release imminent Correct fix is to just use `nemo:26.04` container instead of PyTorch container for megatron-based tests since it always has correct combination of all packages needed for the megatron ecosystem - Done in #1286 --------- Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
1 parent 7e82a5c commit 4e33368

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ dependencies = [
4343
# modelopt.torch
4444
"PyYAML>=6.0",
4545
"omegaconf>=2.3.0",
46-
"pulp",
46+
"pulp<4.0", # breaking changes in upcoming 4.0 release
4747
"pydantic>=2.0",
4848
"regex",
4949
"rich",

tox.ini

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ commands =
8282
[testenv:cuda13-gpu-megatron]
8383
commands_pre =
8484
# Install deps here so that it gets installed even in --current-env
85-
pip install -U megatron-core
85+
# Temporarily disable latest mcore until we fix its nvidia-resiliency-ext dependency
86+
pip install 'megatron-core<0.17.0'
8687
pip install --no-build-isolation git+https://github.com/state-spaces/mamba.git
8788
pip install --no-build-isolation git+https://github.com/Dao-AILab/causal-conv1d.git
8889
pip install -e .[hf,dev-test]

0 commit comments

Comments
 (0)