Skip to content

stb: 0-unstable-2023-01-29 -> 0-unstable-2025-10-26#491159

Open
JulHee wants to merge 5 commits into
NixOS:masterfrom
JulHee:update_stb2
Open

stb: 0-unstable-2023-01-29 -> 0-unstable-2025-10-26#491159
JulHee wants to merge 5 commits into
NixOS:masterfrom
JulHee:update_stb2

Conversation

@JulHee
Copy link
Copy Markdown

@JulHee JulHee commented Feb 16, 2026

Things done

  • Update std to current master

  • Added myself to maintainer

  • Built on platform:

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

  • Tested, as applicable:

  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.

  • Tested basic functionality of all binary files, usually in ./result/bin/.

  • Nixpkgs Release Notes

    • Package update: when the change is major or breaking.

  • NixOS Release Notes

    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.

  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 16, 2026
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Feb 16, 2026
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package and removed 8.has: package (update) This PR updates a package to a newer version 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 19, 2026
andir
andir reviewed Feb 19, 2026
View reviewed changes
Comment thread pkgs/by-name/st/stb_2023/package.nix Outdated
}:

stdenv.mkDerivation (finalAttrs: {
pname = "stb_2023";
Copy link
Copy Markdown
Member

@andir andir Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pname = "stb_2023";
pname = "stb";

@K900
Copy link
Copy Markdown
Contributor

K900 commented Feb 19, 2026

Is there any reason to leave the old version around? Do things not build with newer ones?

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Feb 19, 2026

image

courtesy of @andir

@JulHee
Copy link
Copy Markdown
Author

JulHee commented Feb 19, 2026

Is there any reason to leave the old version around? Do things not build with newer ones?

Gamescope pins the old version before stb_image_resize.h was deprecated in favor of stb_image_resize2.h.

andir
andir approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Full rebuild of the affected packages didn't yield any new failures and the binaries still seem to run.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 19, 2026
@K900
Copy link
Copy Markdown
Contributor

K900 commented Feb 19, 2026

OK so we're down to two packages. Can we patch them instead of vendoring an old stb?

@hzeller
Copy link
Copy Markdown
Contributor

hzeller commented Feb 19, 2026

Somewhat unrelated to this PR, but a good follow-up:
Looks like my pull request on STB that fixes a CVE is still not in stb merged, so might be worthwhile to fetchpatch and apply: nothings/stb#1736

@hzeller
Copy link
Copy Markdown
Contributor

hzeller commented Feb 19, 2026

For someone who is interested to make projects using old image_resize compatible with image_resize2, I found that in an older version of timg, I had written some adapter functions for the resize version. Maybe the leftover projects can be patched with similar adapter function(s) ?
https://github.com/hzeller/timg/blob/52d47bb2346beb6d371173823f9b6474e6ea30f1/src/stb-image-source.cc#L38-L61
(though I think that should be done in separate PRs)

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 27, 2026
@marcin-serwin marcin-serwin mentioned this pull request Mar 19, 2026
Closed
13 tasks
taylorhoward92 pushed a commit to taylorhoward92/nixpkgs that referenced this pull request Apr 4, 2026
@claude
gamescope: add compatibility patch for stb_image_resize2.h
b20f845 
Adds a patch that supports both the old stb_image_resize.h and the new
stb_image_resize2.h using __has_include for compile-time detection. This
prepares gamescope for the upcoming stb update (NixOS#491159)
which removes stb_image_resize.h in favor of stb_image_resize2.h.

Tested against both old stb (0-unstable-2023-01-29) and new stb
(0-unstable-2025-10-25) on x86_64-linux.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@taylorhoward92 taylorhoward92 mentioned this pull request Apr 4, 2026
Merged
13 tasks
taylorhoward92 pushed a commit to taylorhoward92/nixpkgs that referenced this pull request Apr 4, 2026
@claude
gamescope: add compatibility patch for stb_image_resize2.h
750d8bf 
Adds a patch that supports both the old stb_image_resize.h and the new
stb_image_resize2.h using __has_include for compile-time detection. This
prepares gamescope for the upcoming stb update (NixOS#491159)
which removes stb_image_resize.h in favor of stb_image_resize2.h.

Tested against both old stb (0-unstable-2023-01-29) and new stb
(0-unstable-2025-10-25) on x86_64-linux and aarch64-linux.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
taylorhoward92 pushed a commit to taylorhoward92/nixpkgs that referenced this pull request Apr 7, 2026
@claude
gamescope: add compatibility patch for stb_image_resize2.h
f451753 
Pulls in a pending upstream patch (ValveSoftware/gamescope#2130) that
supports both the old stb_image_resize.h and the new stb_image_resize2.h
using __has_include for compile-time detection. This prepares gamescope
for the upcoming stb update (NixOS#491159) which removes
stb_image_resize.h in favor of stb_image_resize2.h.

Tested against both old stb (0-unstable-2023-01-29) and new stb
(0-unstable-2025-10-25) on x86_64-linux and aarch64-linux.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@taylorhoward92 taylorhoward92 mentioned this pull request Apr 7, 2026
Open
19 tasks
samestep pushed a commit to samestep/nixpkgs that referenced this pull request May 15, 2026
@claude @samestep
gamescope: add compatibility patch for stb_image_resize2.h
331fc30 
Pulls in a pending upstream patch (ValveSoftware/gamescope#2130) that
supports both the old stb_image_resize.h and the new stb_image_resize2.h
using __has_include for compile-time detection. This prepares gamescope
for the upcoming stb update (NixOS#491159) which removes
stb_image_resize.h in favor of stb_image_resize2.h.

Tested against both old stb (0-unstable-2023-01-29) and new stb
(0-unstable-2025-10-25) on x86_64-linux and aarch64-linux.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@taylorhoward92
Copy link
Copy Markdown
Contributor

taylorhoward92 commented May 19, 2026

The gamescope package has been patched in #506565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andir andir andir approved these changes

@aware70 aware70 Awaiting requested review from aware70

@Gliczy Gliczy Awaiting requested review from Gliczy

@hatch01 hatch01 Awaiting requested review from hatch01

@hzeller hzeller Awaiting requested review from hzeller

@K900 K900 Awaiting requested review from K900

@liberodark liberodark Awaiting requested review from liberodark

@mksafavi mksafavi Awaiting requested review from mksafavi

@mweinelt mweinelt Awaiting requested review from mweinelt

@nim65s nim65s Awaiting requested review from nim65s

@PedroHLC PedroHLC Awaiting requested review from PedroHLC

@ryand56 ryand56 Awaiting requested review from ryand56

@Scrumplex Scrumplex Awaiting requested review from Scrumplex

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JulHee @K900 @mweinelt @hzeller @taylorhoward92 @andir