ogre-next: add darwin support#501202
Merged
marcin-serwin merged 2 commits intoApr 10, 2026
Merged
Conversation
Contributor
Author
|
Turns out gz-sim actually requires Ogre 2.x not 3.x so I'll need to add that as a new package in a separate PR. Happy for these changes to still go in or for this PR to just be closed. |
marcin-serwin
requested changes
Mar 19, 2026
b174255 to
7dc5dbe
Compare
marcin-serwin
requested changes
Apr 9, 2026
Contributor
marcin-serwin
left a comment
There was a problem hiding this comment.
Please squash fixup commits. Could you also split out adding pkgConfigModules from the darwin fixes into its own commit as they are independent changes?
9229d0d to
37606b4
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add apple-sdk_15 for Metal/Cocoa/OpenGL frameworks on macOS - Move openvr to Linux-only (broken on darwin) - Disable framework bundle output on darwin (incompatible with Nix store) - Guard Xcode-style POST_BUILD commands behind OGRE_BUILD_LIBS_AS_FRAMEWORKS to fix ninja "bad $-escape" error from $(PLATFORM_NAME)/$(CONFIGURATION) - Remove Xcode-centric CMAKE_OSX_SYSROOT overrides (Nix stdenv handles this) - Disable GL3Plus on darwin (missing Khronos headers; Metal is the primary render system on macOS) - Disable both NEON and SSE2 SIMD on aarch64 (fixes build failures) - Extend platforms from linux to unix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
37606b4 to
68101fd
Compare
Contributor
|
marcin-serwin
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds darwin support to ogre-next and also fixes the issue that made this broken on aarch64. This change is being made so that ogre-next can be used as a unix dependency of gz-sim (to be added in a later PR) and is one of two PRs required to support adding gz-sim (the other is #500349).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.