Skip to content

ogre-next-2: init at 2.3.3#501287

Open
taylorhoward92 wants to merge 1 commit into
NixOS:masterfrom
taylorhoward92:add-ogre-next-2
Open

ogre-next-2: init at 2.3.3#501287
taylorhoward92 wants to merge 1 commit into
NixOS:masterfrom
taylorhoward92:add-ogre-next-2

Conversation

@taylorhoward92
Copy link
Copy Markdown
Contributor

@taylorhoward92 taylorhoward92 commented Mar 19, 2026

This adds the previous major version of ogrecave/ogre-next (version 2.3.3) as a new package ogre-next-2.

This version of ogre-next is needed by gazebosim/gz-rendering and the Gazebo ecosystem which I am adding in #505237 as it does not support ogre-next v3.

ogre-next v2 and v3 are API-incompatible, ogre-next tracks v3 and upstream gz-rendering pins v2, so both versions need to coexist in nixpkgs.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

No x86_64-darwin hardware available.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Mar 19, 2026
@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 2 times, most recently from ef5f8ba to b43b1e3 Compare March 20, 2026 09:06
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Mar 20, 2026
@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 2 times, most recently from dc139c7 to 927089a Compare March 22, 2026 02:05
github-actions[bot]

This comment was marked as outdated.

@taylorhoward92 taylorhoward92 marked this pull request as draft March 27, 2026 08:11
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 27, 2026
@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 3 times, most recently from c914dfb to 043d70a Compare March 31, 2026 02:36
@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 4 times, most recently from 2e8185c to 1ea4e4f Compare April 7, 2026 09:59
@taylorhoward92
Copy link
Copy Markdown
Contributor Author

@marcin-serwin it might make sense for you to review this one as well if you have time. Thanks!

@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 3 times, most recently from be5e0a8 to 482b30f Compare April 7, 2026 20:24
@taylorhoward92 taylorhoward92 marked this pull request as ready for review April 7, 2026 20:25
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Apr 7, 2026
@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 3 times, most recently from 8d00518 to 821f2a2 Compare April 10, 2026 04:28
@nixpkgs-ci nixpkgs-ci Bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 13, 2026
@taylorhoward92 taylorhoward92 force-pushed the add-ogre-next-2 branch 2 times, most recently from 62e5163 to 85ae9ca Compare April 14, 2026 11:07
@taylorhoward92
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 501287
Commit: 85ae9caf808db5615f080b9cd57789f4c6c2463b


x86_64-linux

✅ 1 package built:
  • ogre-next-2

aarch64-linux

✅ 1 package built:
  • ogre-next-2

aarch64-darwin

✅ 1 package built:
  • ogre-next-2

Comment thread pkgs/by-name/og/ogre-next-2/package.nix Outdated
# master (v3-0) already has the correct write order; this backports it.
# https://github.com/OGRECave/ogre-next/pull/567
(fetchpatch2 {
url = "https://github.com/OGRECave/ogre-next/pull/567.diff";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please vendor all unmerged PRs to avouid hash mismatches in the future.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated!

@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Apr 18, 2026
@taylorhoward92
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 501287
Commit: ee2149ee42c50d14e4aefec56d169ccd80d72df5


x86_64-linux

✅ 1 package built:
  • ogre-next-2

aarch64-linux

✅ 1 package built:
  • ogre-next-2

aarch64-darwin

✅ 1 package built:
  • ogre-next-2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@taylorhoward92
Copy link
Copy Markdown
Contributor Author

@SuperSandro2000 are you able to have another look at this?

@taylorhoward92
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 501287
Commit: a84e20293ac9b50b6cd1c192872e33d2fecbc0eb


x86_64-linux

✅ 1 package built:
  • ogre-next-2

aarch64-linux

✅ 1 package built:
  • ogre-next-2

aarch64-darwin

✅ 1 package built:
  • ogre-next-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants