ogre-next-2: init at 2.3.3#501287
Open
taylorhoward92 wants to merge 1 commit into
Open
Conversation
ef5f8ba to
b43b1e3
Compare
dc139c7 to
927089a
Compare
927089a to
aa2e868
Compare
c914dfb to
043d70a
Compare
19 tasks
2e8185c to
1ea4e4f
Compare
Contributor
Author
|
@marcin-serwin it might make sense for you to review this one as well if you have time. Thanks! |
be5e0a8 to
482b30f
Compare
8d00518 to
821f2a2
Compare
62e5163 to
85ae9ca
Compare
Contributor
Author
|
SuperSandro2000
requested changes
Apr 18, 2026
| # master (v3-0) already has the correct write order; this backports it. | ||
| # https://github.com/OGRECave/ogre-next/pull/567 | ||
| (fetchpatch2 { | ||
| url = "https://github.com/OGRECave/ogre-next/pull/567.diff"; |
Member
There was a problem hiding this comment.
Please vendor all unmerged PRs to avouid hash mismatches in the future.
Contributor
Author
There was a problem hiding this comment.
Good point. Updated!
85ae9ca to
ee2149e
Compare
Contributor
Author
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ee2149e to
a84e202
Compare
Contributor
Author
|
@SuperSandro2000 are you able to have another look at this? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the previous major version of ogrecave/ogre-next (version 2.3.3) as a new package ogre-next-2.
This version of ogre-next is needed by gazebosim/gz-rendering and the Gazebo ecosystem which I am adding in #505237 as it does not support ogre-next v3.
ogre-next v2 and v3 are API-incompatible, ogre-next tracks v3 and upstream gz-rendering pins v2, so both versions need to coexist in nixpkgs.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.No x86_64-darwin hardware available.