Merge pull request #1622 from OceanStreamIO/oceanstream/fix-type-hint-and-scalar-extraction

fix: correct SNR_threshold type annotation and xarray scalar extraction

Author: LOCEANlloydizard

echopype/calibrate/cal_params.py

@@ -410,7 +410,7 @@ def _get_fs():
             # loop through channel since transceiver can vary
             fs = []
             for ch in vend["channel"]:
-                tcvr_type = vend["transceiver_type"].sel(channel=ch).data.tolist().upper()
+                tcvr_type = vend["transceiver_type"].sel(channel=ch).values.item().upper()
                 fs.append(default_params["receiver_sampling_frequency"][tcvr_type])
             return xr.DataArray(fs, dims=["channel"], coords={"channel": vend["channel"]})
 

echopype/clean/api.py

@@ -439,7 +439,7 @@ def remove_background_noise(
     ping_num: int,
     range_sample_num: int,
     background_noise_max: str = None,
-    SNR_threshold: float = "3.0dB",
+    SNR_threshold: str = "3.0dB",
 ) -> xr.Dataset:
     """
     Remove noise by using estimates of background noise