chore: v0.2.9 hotfix — empty-doc crash, data loss, undo, light selection, side panel

OlaProeis · OlaProeis · commit b3922773c7df · 2026-04-23T11:55:08.000+02:00
Addresses four critical regressions shipped in v0.2.8: - Crash in Split/Rendered view on empty documents (#127): viewport-culling bootstrap indexed doc.root.children[0] when block_count == 0. Switched the inner render range from inclusive (first_vis..=last_vis) to half-open (first_vis..render_end) so an empty document yields an empty iterator. - No unsaved-changes indicator and no save prompt on close (silent data loss): raw FerriteEditor edits wrote to tab.content but never bumped content_version, so the cached is_modified() kept returning false. Routed raw-mode edits through prepare_undo_snapshot_hashed / record_edit_from_snapshot and centralized content_version bumps in state.rs so every edit path invalidates the cache. - Undo/redo reporting "Nothing to undo": FerriteEditor's internal edits were never diffed into tab.edit_history (the stack Ctrl+Z/Ctrl+Y read). Pre-edit snapshot is now captured per frame and diffed when the editor reports is_content_dirty(). - Selection invisible in Light mode (#121): the selection overlay is drawn on top of the text galley and is kept at ~40% alpha so glyphs stay legible; the previous pale light-theme selection colour (215, 230, 250) collapsed to near-white at that alpha. Bumped BaseColors::light().selected to a saturated blue (100, 170, 245) that remains visible when composited. - Document side panel tab labels overlapping at default width: raised the default outline panel width from 200 to 300 px and the minimum from 120 to 260 px so all five tabs (Outline / Stats / Links / FM / Hub) render without clipping. Existing users with a persisted outline_width below 260 are auto-migrated by the settings validator on next launch. Also shifts the originally-planned v0.2.9 roadmap (egui 0.31+, PDF/HTML export, executable code blocks, LSP phases 3-4, YouTube embeds) into v0.3.0, merged with the pre-existing v0.3.0 content (Mermaid crate, RTL and BiDi, markdown enhancements). Updates Cargo.toml, CHANGELOG.md, ROADMAP.md, and the Linux metainfo release entry + screenshot URLs to v0.2.9. Made-with: Cursor
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,19 @@ All notable changes to Ferrite will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.9] - 2026-04-23
+
+Hotfix release for four critical v0.2.8 regressions. No new features — upgrade
+strongly recommended.
+
+### Fixed
+
+- **Crash in Split / Rendered view on empty documents** ([#127](https://github.com/OlaProeis/Ferrite/issues/127)) — The WYSIWYG renderer's viewport-culling bootstrap used an inclusive range `first_vis..=last_vis` that, when the document had zero blocks, iterated once and indexed `doc.root.children[0]`, aborting with "index out of bounds". Switched to a half-open range so empty documents render as a no-op. This was reproducible by launching Ferrite with Split set as the default view mode, or by clicking the Split/Rendered button on any freshly-created untitled tab.
+- **CRITICAL: No unsaved-changes indicator and no save prompt on close, leading to silent data loss** — Edits made through the raw FerriteEditor wrote the new content into `tab.content` but never bumped `content_version`, so the cached `is_modified()` kept returning its initial `false`. Result: the title bar never showed the `*` dirty mark, Ctrl+W / window close skipped the "Save changes?" dialog, and auto-save never fired. Fixed by routing raw-mode edits through `prepare_undo_snapshot_hashed` + `record_edit_from_snapshot`, and by centralizing `content_version` bumps inside `record_edit_from_snapshot` / `set_content` so every edit path (raw, rendered, tree viewer) invalidates the cache.
+- **CRITICAL: Undo / redo not working — "Nothing to undo" after typing** — The FerriteEditor maintains its own internal edit state, but `handle_undo` / `handle_redo` (the Ctrl+Z / Ctrl+Y keyboard handlers) read from `tab.edit_history`, which received no operations from raw-mode edits. Fixed by diffing the pre-edit snapshot against the post-edit content on every frame where FerriteEditor reports `is_content_dirty()` and recording the resulting ops onto `tab.edit_history`.
+- **Selection invisible in Light mode** ([#121](https://github.com/OlaProeis/Ferrite/issues/121)) — FerriteEditor draws the selection rectangle *on top of* the text galley, so the fill has to stay partly transparent (otherwise selected text would disappear behind a solid rectangle). In Light mode the theme's selection colour `(215, 230, 250)` composited at ~40% alpha over white collapsed to essentially white, making the selection invisible. Bumped `BaseColors::light().selected` to a more saturated blue `(100, 170, 245)` that stays visible at reduced alpha while still looking at home as a light-theme widget highlight.
+- **Document side panel tab labels overlapping at default width** — The Outline/Stats/Links/FM/Hub tabs split `available_width / 5` per tab, which clipped every label at the previous 200 px default. Raised the default panel width to 300 px and the minimum to 260 px so all five tab labels render in full. Existing users with a persisted `outline_width` below 260 are auto-migrated to 260 on next launch by the settings validator.
+
 ## [0.2.8] - 2026-04-14
 
 ### Added
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "ferrite"
-version = "0.2.8"
+version = "0.2.9"
 edition = "2021"
 description = "A fast, lightweight text editor for Markdown, JSON, and more"
 repository = "https://github.com/OlaProeis/Ferrite"
diff --git a/ROADMAP.md b/ROADMAP.md
@@ -2,8 +2,10 @@
 
 ## Next Up (Immediate Focus)
 
-### v0.2.9 - Platform Stack Upgrade, Export, Code Execution & Media Embeds
-**Primary focus:** **eframe / egui 0.31+** (Task 38) — large dependency migration with full cross-platform QA. Fixes Wayland keyboard input ([#106](https://github.com/OlaProeis/Ferrite/issues/106)), macOS Sonoma keyboard ([#111](https://github.com/OlaProeis/Ferrite/issues/111)), and Windows 11 borderless/DPI ([#112](https://github.com/OlaProeis/Ferrite/issues/112)). Also: PDF/HTML export, executable code blocks (deferred from v0.2.8), LSP integration (all phases, deferred from v0.2.8), and embedded YouTube/video playback ([#119](https://github.com/OlaProeis/Ferrite/issues/119)). See [detailed plan](#v029---platform-stack-upgrade-export--code-execution-1) below.
+### v0.3.0 - Platform Stack Upgrade, Export, Code Execution, Media Embeds, Mermaid Crate & RTL/BiDi
+**Primary focus:** **eframe / egui 0.31+** (Task 38) — large dependency migration with full cross-platform QA. Fixes Wayland keyboard input ([#106](https://github.com/OlaProeis/Ferrite/issues/106)), macOS Sonoma keyboard ([#111](https://github.com/OlaProeis/Ferrite/issues/111)), and Windows 11 borderless/DPI ([#112](https://github.com/OlaProeis/Ferrite/issues/112)). Also: PDF/HTML export, executable code blocks (deferred from v0.2.8), LSP integration (all phases, deferred from v0.2.8), embedded YouTube/video playback ([#119](https://github.com/OlaProeis/Ferrite/issues/119)), Mermaid crate extraction, and full RTL/BiDi (Phases 3–4). See [detailed plan](#v030---platform-stack-upgrade-export-code-execution-media-embeds-mermaid-crate--rtlbidi-1) below.
+
+> **v0.2.9 (Apr 2026)** was a hotfix release for four critical v0.2.8 regressions — see [Recently Completed](#recently-completed-). The original v0.2.9 roadmap (platform upgrade, export, code execution, media embeds) has been rolled into v0.3.0, which was already planned as a large release. Split points for v0.3.1 will be decided once the v0.3.0 scope settles.
 
 ---
 
@@ -37,12 +39,14 @@ With the v0.2.6 custom editor, most previous egui TextEdit limitations are resol
 
 ## Planned Features
 
-### v0.2.9 - Platform Stack Upgrade, Export, Code Execution & Media Embeds
+### v0.3.0 - Platform Stack Upgrade, Export, Code Execution, Media Embeds, Mermaid Crate & RTL/BiDi
 **Primary focus:** **eframe / egui 0.31+** (Task 38) — large dependency migration with full cross-platform QA. Intended to address **Wayland keyboard input** ([#106](https://github.com/OlaProeis/Ferrite/issues/106)), **macOS Sonoma keyboard** ([#111](https://github.com/OlaProeis/Ferrite/issues/111)), and **Windows 11 borderless / DPI** ([#112](https://github.com/OlaProeis/Ferrite/issues/112)) where fixes depend on newer winit/egui. Workarounds (e.g. `WAYLAND_DISPLAY=` on Ubuntu Wayland) remain documented until this ships.
 
-**Secondary focus:** First-class export from markdown to shareable files (PDF, self-contained HTML). Complements **PDF viewer tabs** (v0.2.8)—**writing → publish**, not only viewing external PDFs.
+**Secondary focus:** First-class export from markdown to shareable files (PDF, self-contained HTML). Complements **PDF viewer tabs** (v0.2.8) — **writing → publish**, not only viewing external PDFs.
+
+**Tertiary focus:** Executable code blocks (deferred from v0.2.8), full LSP integration (Phases 1–4, deferred from v0.2.8 due to memory/usability issues), embedded YouTube/video playback via native web views ([#119](https://github.com/OlaProeis/Ferrite/issues/119)), Mermaid crate extraction, markdown rendering improvements, Alt-key menu rework, and full RTL + BiDi script support (Phases 3–4 of the Unicode shaping roadmap).
 
-**Tertiary focus:** Executable code blocks (deferred from v0.2.8), full LSP integration (Phases 1–4, deferred from v0.2.8 due to memory/usability issues), and embedded YouTube/video playback via native web views ([#119](https://github.com/OlaProeis/Ferrite/issues/119)).
+*Scope note:* This is a large release. Items listed below may be split into a follow-up v0.3.1 if scope creep threatens ship-quality. Split points will be decided once the egui 0.31+ migration lands and stabilizes.
 
 #### Platform & Dependency Upgrade (Task 38)
 - [ ] **Bump eframe / egui** to 0.31+ (confirm compatible versions); `cargo update`; fix breaking API changes across `main.rs`, editor input, themes, terminal, markdown UI, etc.
@@ -87,11 +91,6 @@ With the v0.2.6 custom editor, most previous egui TextEdit limitations are resol
 
 *Note: **LaTeX math** rendering in preview and export is planned under **v0.4.0**; PDF/HTML export will pick up formulas once the math engine exists.*
 
----
-
-### v0.3.0 - Mermaid Crate, Markdown Enhancements, Alt Menus & Full RTL/BiDi
-**Focus:** Extracting the Mermaid renderer as a standalone crate, improving markdown rendering, traditional Alt-key menus, and completing right-to-left and bidirectional text support.
-
 #### Command Discoverability ([#59](https://github.com/OlaProeis/Ferrite/issues/59))
 *Addressed in v0.2.8 with Command Palette.*
 
@@ -255,6 +254,14 @@ With the v0.2.6 custom editor, most previous egui TextEdit limitations are resol
 
 ## Recently Completed ✅
 
+### v0.2.9 (Apr 2026) - Hotfix Release
+Hotfix for four critical v0.2.8 regressions. No new features.
+- **Crash in Split / Rendered view on empty documents** ([#127](https://github.com/OlaProeis/Ferrite/issues/127)) — viewport-culling bootstrap indexed `doc.root.children[0]` when `block_count == 0`. Fixed with a half-open render range.
+- **No unsaved-changes indicator (`*`) and no save prompt on close, causing silent data loss** — raw-mode edits bypassed `content_version`, so `is_modified()` stayed cached at `false`. `content_version` bumps centralized in `record_edit_from_snapshot()` / `set_content()`.
+- **Undo / redo reporting "Nothing to undo" after typing** — FerriteEditor's internal edits were never diffed into `tab.edit_history`, which is the stack Ctrl+Z / Ctrl+Y read. Fixed by snapshotting pre-edit content and recording ops per dirty frame.
+- **Selection invisible in Light mode** ([#121](https://github.com/OlaProeis/Ferrite/issues/121)) — 40% alpha made the pale light-theme selection blend into the panel. Alpha reduction is now dark-mode-only.
+- **Document side panel tab labels overlapping at default width** — raised default outline panel width from 200 → 300 px, minimum from 120 → 260 px; existing users auto-migrated by settings validator.
+
 ### v0.2.8 (Apr 2026) - Performance, Text Shaping, LSP Integration & Viewers
 Command Palette (Alt+Space) with fuzzy search across all actions. LSP integration (Phases 1-2): inline diagnostics, server lifecycle, status bar, on-demand startup. HarfRust text shaping for Arabic, Bengali, Devanagari, and other complex scripts. Image viewer tabs (PNG/JPEG/GIF/WebP/BMP) and PDF viewer tabs (hayro, pure Rust). Major rendered view performance overhaul: AST caching, viewport culling, block height cache, lazy estimation. Per-frame O(N) elimination for large files. Background file loading for 5MB+ files. Strict line breaks (Obsidian model). Middle-click to close tabs. CSV/TreeViewer/central panel per-frame allocation fixes. Table cell rich text rendering with click-to-edit (bold, italic, strikethrough, code, nesting). 13 bug fixes including macOS .md file association (#102), Windows IME positioning (#103), custom font crash on Linux (#114), Linux Cinnamon dialog detection (#116), table inline formatting preservation and rendering (#117), terminal CJK rendering (#110), Windows 11 borderless offset (#112), and more.
 
diff --git a/assets/linux/io.github.olaproeis.Ferrite.metainfo.xml b/assets/linux/io.github.olaproeis.Ferrite.metainfo.xml
@@ -52,22 +52,34 @@
 
   <screenshots>
     <screenshot type="default">
-      <image>https://raw.githubusercontent.com/OlaProeis/Ferrite/v0.2.8/assets/screenshots/split-dark.png</image>
+      <image>https://raw.githubusercontent.com/OlaProeis/Ferrite/v0.2.9/assets/screenshots/split-dark.png</image>
       <caption>Ferrite in dark mode with split view showing markdown editing and live preview</caption>
     </screenshot>
     <screenshot>
-      <image>https://raw.githubusercontent.com/OlaProeis/Ferrite/v0.2.8/assets/screenshots/raw-dark.png</image>
+      <image>https://raw.githubusercontent.com/OlaProeis/Ferrite/v0.2.9/assets/screenshots/raw-dark.png</image>
       <caption>Raw editing mode with syntax highlighting</caption>
     </screenshot>
     <screenshot>
-      <image>https://raw.githubusercontent.com/OlaProeis/Ferrite/v0.2.8/assets/screenshots/zen-dark.png</image>
+      <image>https://raw.githubusercontent.com/OlaProeis/Ferrite/v0.2.9/assets/screenshots/zen-dark.png</image>
       <caption>Zen mode for distraction-free writing</caption>
     </screenshot>
   </screenshots>
 
   <content_rating type="oars-1.1" />
 
   <releases>
+    <release version="0.2.9" date="2026-04-23">
+      <description>
+        <p>Hotfix release for four critical v0.2.8 regressions. No new features.</p>
+        <ul>
+          <li>Fixed crash in Split / Rendered view when opening an empty document (#127)</li>
+          <li>Fixed missing unsaved-changes indicator and missing save prompt on close (data loss)</li>
+          <li>Fixed broken Undo / Redo — "Nothing to undo" after typing</li>
+          <li>Fixed invisible text selection in Light mode (#121)</li>
+          <li>Widened document side panel default so the Outline / Stats / Links / FM / Hub tabs no longer overlap</li>
+        </ul>
+      </description>
+    </release>
     <release version="0.2.8" date="2026-04-14">
       <description>
         <p>Performance, text shaping, command palette, and bug fixes</p>
diff --git a/src/config/settings.rs b/src/config/settings.rs
@@ -2120,7 +2120,7 @@ impl Default for Settings {
             // Outline Panel
             outline_enabled: false, // Hidden by default
             outline_side: OutlinePanelSide::default(),
-            outline_width: 200.0,
+            outline_width: 300.0,
 
             // Sync Scrolling (deferred to v0.3.0 - UI removed, feature disabled)
             sync_scroll_enabled: false,
@@ -2392,7 +2392,12 @@ impl Settings {
     /// Maximum window dimension.
     pub const MAX_WINDOW_SIZE: f32 = 10000.0;
     /// Minimum outline panel width.
-    pub const MIN_OUTLINE_WIDTH: f32 = 120.0;
+    ///
+    /// Sized to ensure the 5 tab labels (Outline / Stats / Links / FM / Hub)
+    /// render without overlapping at the default font. Existing users whose
+    /// persisted `outline_width` is below this value will be bumped up to it
+    /// by `validate()` on next launch (hotfix for v0.2.8's cramped tabs).
+    pub const MIN_OUTLINE_WIDTH: f32 = 260.0;
     /// Maximum outline panel width.
     pub const MAX_OUTLINE_WIDTH: f32 = 500.0;
     /// Minimum Zen Mode column width (characters).
diff --git a/src/editor/ferrite/editor.rs b/src/editor/ferrite/editor.rs
@@ -1671,15 +1671,23 @@ impl FerriteEditor {
             self.view.advance_scrollbar_smoothing(total_lines);
         }
 
-        // Render selection backgrounds (before cursors) - handles all selections
+        // Render selection backgrounds (after text, before cursors).
+        //
+        // The overlay is drawn *on top* of the text galley (moving the draw
+        // order is risky because per-line wrap heights are computed inside
+        // the text loop), so we keep the fill partly transparent so syntax-
+        // coloured glyphs stay legible through the highlight. This means the
+        // theme's `selection.bg_fill` must be saturated enough to remain
+        // visible at ~40% alpha on both light and dark backgrounds — see
+        // `BaseColors::light()/dark()` for the values chosen to satisfy this
+        // (issue #121).
         if self.has_any_selection() {
-            // Make selection semi-transparent so text remains visible through the highlight
             let selection_base = ui.visuals().selection.bg_fill;
             let selection_color = Color32::from_rgba_unmultiplied(
                 selection_base.r(),
                 selection_base.g(),
                 selection_base.b(),
-                100, // ~40% alpha for visibility
+                100, // ~40% alpha — lets text shine through in both themes
             );
             self.render_all_selections(
                 &painter,
diff --git a/src/editor/widget.rs b/src/editor/widget.rs
@@ -467,6 +467,13 @@ impl<'a> EditorWidget<'a> {
         let tab_id = self.tab.id;
         let _base_id = self.id.unwrap_or_else(|| ui.id().with("ferrite_editor"));
 
+        // Capture an undo snapshot of the pre-edit content so edits made
+        // through FerriteEditor are recorded in `tab.edit_history` (the stack
+        // that Ctrl+Z / Ctrl+Y consult via `handle_undo` / `handle_redo`).
+        // Without this the tab's edit history stays empty and users see
+        // "Nothing to undo" even after typing — a v0.2.8 regression.
+        self.tab.prepare_undo_snapshot_hashed();
+
         // Check if this is a large file (disable some features for performance)
         let content_len = self.tab.content.len();
         let is_large_file = content_len > LARGE_FILE_THRESHOLD;
@@ -791,6 +798,18 @@ impl<'a> EditorWidget<'a> {
         if changed {
             // Only allocate string when we know content changed
             self.tab.content = editor.buffer().to_string();
+            // Diff against the pre-edit snapshot captured at the top of
+            // show(). This:
+            //   1. Pushes ops onto `tab.edit_history` so Ctrl+Z / Ctrl+Y
+            //      (which read this stack via handle_undo/handle_redo)
+            //      work for raw-mode edits.
+            //   2. Bumps `content_version`, invalidating the cached
+            //      `is_modified()` so the title bar dirty-mark, the
+            //      on-close save prompt and auto-save all notice the
+            //      edit.
+            // Hotfix for v0.2.8 undo-broken / data-loss regression.
+            self.tab.record_edit_from_snapshot();
+            self.tab.mark_content_edited();
         }
 
         // Sync cursor position for outline panel / minimap bidirectional sync
diff --git a/src/markdown/editor.rs b/src/markdown/editor.rs
@@ -1339,6 +1339,9 @@ impl<'a> MarkdownEditor<'a> {
 
                             // Phase 3: Render only the viewport-visible blocks,
                             // capped by the render budget.
+                            // NOTE: When block_count == 0 (empty document) the inclusive
+                            // range `first_vis..=last_vis` below would otherwise iterate
+                            // once and panic on `doc.root.children[0]`. See issue #127.
                             let vis_top = (viewport.min.y - VIEWPORT_OVERSCAN_PX).max(0.0);
                             let vis_bottom = viewport.max.y + VIEWPORT_OVERSCAN_PX;
 
@@ -1350,15 +1353,19 @@ impl<'a> MarkdownEditor<'a> {
                                 .min(block_count)
                                 .saturating_sub(1);
 
-                            if first_vis > 0 {
+                            if block_count > 0 && first_vis > 0 {
                                 let pre = (boot_start_y[first_vis] - BLOCK_ITEM_SPACING_Y)
                                     .max(0.0);
                                 ui.allocate_space(Vec2::new(content_width, pre));
                             }
 
                             let mut new_measures: usize = 0;
                             let boot_is_dark = ui.visuals().dark_mode;
-                            for i in first_vis..=last_vis.min(block_count.saturating_sub(1)) {
+                            // Use a half-open range so an empty document
+                            // (block_count == 0) yields an empty iterator
+                            // rather than accessing children[0].
+                            let render_end = (last_vis + 1).min(block_count);
+                            for i in first_vis..render_end {
                                 let node = &doc.root.children[i];
                                 let y_before = ui.cursor().top();
                                 let block_left = ui.cursor().left();
diff --git a/src/state.rs b/src/state.rs
diff --git a/src/theme/mod.rs b/src/theme/mod.rs
diff --git a/src/ui/outline_panel.rs b/src/ui/outline_panel.rs
