Skip to content

Commit f93e207

Browse files
committed
Temporarily disable Windows code signing (awaiting SignPath approval)
1 parent 9916383 commit f93e207

1 file changed

Lines changed: 38 additions & 42 deletions

File tree

.github/workflows/release.yml

Lines changed: 38 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -80,40 +80,39 @@ jobs:
8080
ferrite-windows-x64.msi
8181
8282
# Sign Windows artifacts with SignPath (OSS code signing)
83-
sign-windows:
84-
name: Sign Windows Artifacts
85-
needs: [build-windows]
86-
runs-on: ubuntu-latest
87-
88-
steps:
89-
# SignPath receives artifacts directly from GitHub - no need to re-download/re-zip
90-
# The artifact config's outer <zip-file> matches GitHub's automatic artifact wrapper
91-
- name: Submit to SignPath
92-
id: signpath
93-
uses: signpath/github-action-submit-signing-request@v2
94-
with:
95-
api-token: '${{ secrets.SIGNPATH_API_TOKEN }}'
96-
organization-id: '${{ secrets.SIGNPATH_ORGANIZATION_ID }}'
97-
project-slug: 'ferrite'
98-
signing-policy-slug: 'release-signing'
99-
github-artifact-id: '${{ needs.build-windows.outputs.artifact-id }}'
100-
wait-for-completion: true
101-
output-artifact-directory: 'signed'
102-
103-
- name: List signed artifacts
104-
run: ls -la signed/
105-
106-
- name: Upload signed portable zip
107-
uses: actions/upload-artifact@v4
108-
with:
109-
name: ferrite-portable-windows-x64
110-
path: signed/ferrite-portable-windows-x64.zip
111-
112-
- name: Upload signed MSI
113-
uses: actions/upload-artifact@v4
114-
with:
115-
name: ferrite-windows-msi
116-
path: signed/ferrite-windows-x64.msi
83+
# TEMPORARILY DISABLED - awaiting SignPath organization approval
84+
# sign-windows:
85+
# name: Sign Windows Artifacts
86+
# needs: [build-windows]
87+
# runs-on: ubuntu-latest
88+
#
89+
# steps:
90+
# - name: Submit to SignPath
91+
# id: signpath
92+
# uses: signpath/github-action-submit-signing-request@v2
93+
# with:
94+
# api-token: '${{ secrets.SIGNPATH_API_TOKEN }}'
95+
# organization-id: '${{ secrets.SIGNPATH_ORGANIZATION_ID }}'
96+
# project-slug: 'ferrite'
97+
# signing-policy-slug: 'release-signing'
98+
# github-artifact-id: '${{ needs.build-windows.outputs.artifact-id }}'
99+
# wait-for-completion: true
100+
# output-artifact-directory: 'signed'
101+
#
102+
# - name: List signed artifacts
103+
# run: ls -la signed/
104+
#
105+
# - name: Upload signed portable zip
106+
# uses: actions/upload-artifact@v4
107+
# with:
108+
# name: ferrite-portable-windows-x64
109+
# path: signed/ferrite-portable-windows-x64.zip
110+
#
111+
# - name: Upload signed MSI
112+
# uses: actions/upload-artifact@v4
113+
# with:
114+
# name: ferrite-windows-msi
115+
# path: signed/ferrite-windows-x64.msi
117116

118117
build-linux:
119118
name: Build Linux
@@ -244,21 +243,18 @@ jobs:
244243
# Create GitHub Release with all artifacts
245244
release:
246245
name: Create Release
247-
needs: [sign-windows, build-linux, build-macos-arm64, build-macos-intel]
246+
# NOTE: Using build-windows instead of sign-windows until SignPath approval
247+
needs: [build-windows, build-linux, build-macos-arm64, build-macos-intel]
248248
runs-on: ubuntu-latest
249249
permissions:
250250
contents: write
251251

252252
steps:
253-
- name: Download signed Windows portable zip artifact
254-
uses: actions/download-artifact@v4
255-
with:
256-
name: ferrite-portable-windows-x64
257-
258-
- name: Download signed Windows MSI artifact
253+
# NOTE: Downloading unsigned artifacts until SignPath approval
254+
- name: Download unsigned Windows artifacts
259255
uses: actions/download-artifact@v4
260256
with:
261-
name: ferrite-windows-msi
257+
name: unsigned-windows-artifacts
262258

263259
- name: Download Linux artifact
264260
uses: actions/download-artifact@v4

0 commit comments

Comments
 (0)