Add missing value tag test to cupsCheckDestSupported.

michaelrsweet · michaelrsweet · commit 5539b2d97b72 · 2026-04-22T15:04:19.000-04:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -11,6 +11,7 @@ v3.0.2 - YYYY-MM-DD
 - Fixed exporting of JSON with very large numbers.
 - Fixed page header validation in `cupsRasterReadHeader` and
   `cupsRasterWriteHeader` for banded raster data.
+- Fixed potential crash bug in `cupsCheckDestSupported` function.
 
 
 v3.0.1 - 2026-04-09
diff --git a/cups/dest-options.c b/cups/dest-options.c
@@ -181,7 +181,7 @@ cupsCheckDestSupported(
     return (true);
 
   // Compare values...
-  if (!strcmp(option, "media") && !strncmp(value, "custom_", 7))
+  if (!strcmp(option, "media") && (ippGetValueTag(attr) == IPP_TAG_KEYWORD || ippGetValueTag(attr) == IPP_TAG_NAME || ippGetValueTag(attr) == IPP_TAG_NAMELANG) && !strncmp(value, "custom_", 7))
   {
     // Check range of custom media sizes...
     pwg_media_t	*pwg;		// Current PWG media size info

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ cupsCheckDestSupported(`
`181`	`181`	`return (true);`
`182`	`182`
`183`	`183`	`// Compare values...`
`184`		`- if (!strcmp(option, "media") && !strncmp(value, "custom_", 7))`
	`184`	`+ if (!strcmp(option, "media") && (ippGetValueTag(attr) == IPP_TAG_KEYWORD \|\| ippGetValueTag(attr) == IPP_TAG_NAME \|\| ippGetValueTag(attr) == IPP_TAG_NAMELANG) && !strncmp(value, "custom_", 7))`
`185`	`185`	`{`
`186`	`186`	`// Check range of custom media sizes...`
`187`	`187`	`pwg_media_t *pwg; // Current PWG media size info`