Skip to content

Add Gen IV honey tree encounters#1498

Merged
Naramsim merged 6 commits into
PokeAPI:masterfrom
Machine-Maker:feature/gen-iv-honey-trees
May 13, 2026
Merged

Add Gen IV honey tree encounters#1498
Naramsim merged 6 commits into
PokeAPI:masterfrom
Machine-Maker:feature/gen-iv-honey-trees

Conversation

@Machine-Maker
Copy link
Copy Markdown
Contributor

@Machine-Maker Machine-Maker commented Apr 19, 2026

Change description

Add honey tree encounters to Gen IV games.

Added 7 slots per vg, 1-6 either have honey-tree-group-a or honey-tree-group-b as condition, 7 has 100% chance with honey-tree-group-c. Descriptions for each encounter condition value say 70% on group a for non-munchlax trees, 20% for munchlax-trees. B and C say correct respective chance.

Added 1 new location area, floaroma-meadow-area which didn't exist before because there aren't any pokemon encounters except Honey trees.

AI coding assistance disclosure

Claude Code to generate script to add csv lines for the large file change (encounters/conditions)

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Machine-Maker Machine-Maker force-pushed the feature/gen-iv-honey-trees branch from 9685ae1 to 9416706 Compare April 25, 2026 05:10
jemarq04
jemarq04 suggested changes May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jemarq04 jemarq04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encounters all look great! Just a minor request to fill out some prose. Thanks!

Comment thread data/v2/csv/encounter_conditions.csv Outdated
@Machine-Maker Machine-Maker requested a review from jemarq04 May 9, 2026 13:25
jemarq04
jemarq04 suggested changes May 9, 2026
View reviewed changes
Comment thread data/v2/csv/encounter_condition_value_prose.csv Outdated
@Machine-Maker Machine-Maker requested a review from jemarq04 May 9, 2026 14:42
@jemarq04
Copy link
Copy Markdown
Member

jemarq04 commented May 12, 2026

Ok, now that the great marsh encounters were merged, go ahead and update the encounter IDs and I'll do a quick glance over to make sure things are accurate before final approval. Thanks!

@Machine-Maker
Copy link
Copy Markdown
Contributor Author

Machine-Maker commented May 12, 2026

Ok, updated various ids

jemarq04
jemarq04 approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jemarq04 jemarq04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! :)

@Naramsim Naramsim merged commit 492fd4f into PokeAPI:master May 13, 2026
9 checks passed
@Naramsim
Copy link
Copy Markdown
Member

Naramsim commented May 13, 2026

Thank you so much for adding in the data and for reviewing!

@pokeapi-machine-user
Copy link
Copy Markdown

pokeapi-machine-user commented May 13, 2026

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@Machine-Maker Machine-Maker deleted the feature/gen-iv-honey-trees branch May 13, 2026 04:19
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request May 13, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1498
4ad2814
@pokeapi-machine-user pokeapi-machine-user mentioned this pull request May 13, 2026
Merged
@pokeapi-machine-user
Copy link
Copy Markdown

pokeapi-machine-user commented May 13, 2026

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request May 13, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1498 (#373)
12bea82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jemarq04 jemarq04 jemarq04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Machine-Maker @jemarq04 @Naramsim @pokeapi-machine-user