Enhance download_test_videos fixture

Refactor video downloading logic and improve error handling.

Signed-off-by: Muhammad Rizwan Munawar <muhammadrizwanmunawar123@gmail.com>

Author: RizwanMunawar

tests/core.py

@@ -14,48 +14,47 @@
 
 @pytest.fixture
 def download_test_videos():
-    """Download real test videos from GitHub releases."""
+    """Download real test videos from GitHub releases. Fail if not available."""
     temp_dir = tempfile.mkdtemp(prefix="streamgrid_test_")
-    video_paths = []
-
-    for i, url in enumerate(video_urls):
-        try:
-            print(f"Downloading Video{i + 1}.mp4...")
-            response = requests.get(url, timeout=120)
-            if response.status_code == 200:
-                video_path = os.path.join(temp_dir, f"Video{i + 1}.mp4")
-                with open(video_path, "wb") as f:
-                    f.write(response.content)
-                video_paths.append(video_path)
-                print(f"✓ Downloaded Video{i + 1}.mp4")
-            else:
-                print(
-                    f"✗ Failed to download Video{i + 1}.mp4 (Status: {response.status_code})"
-                )
-        except requests.RequestException as e:
-            print(f"✗ Error downloading Video{i + 1}.mp4: {e}")
-
-    # Change to temp directory so relative paths work
     original_dir = os.getcwd()
     os.chdir(temp_dir)
 
+    video_paths = []
+    for i, url in enumerate(video_urls, start=1):
+        print(f"Downloading Video{i}.mp4...")
+        try:
+            r = requests.get(url, timeout=60)
+            r.raise_for_status()
+        except Exception as e:
+            # Fail instead of skip or dummy
+            pytest.fail(f"Failed to download Video{i}.mp4: {e}")
+
+        video_path = os.path.join(temp_dir, f"Video{i}.mp4")
+        with open(video_path, "wb") as f:
+            f.write(r.content)
+        video_paths.append(video_path)
+        print(f"✓ Downloaded Video{i}.mp4")
+
     yield video_paths
 
-    # Cleanup
     os.chdir(original_dir)
     shutil.rmtree(temp_dir, ignore_errors=True)
 
 
 def test_usage_code(download_test_videos):
-    """Test the usage of Streamgrid."""
-    # Video paths
+    """Test the usage of StreamGrid with real videos."""
     paths = ["Video1.mp4", "Video2.mp4"]
     model = YOLO("yolo11n.pt")
 
-    # Test initialization
     sg = StreamGrid(paths, model)
-    assert sg is not None
-
-    print("✓ StreamGrid initialization successful")
-    print("✓ All videos loaded correctly")
-    print("✓ YOLO model loaded successfully")
+    try:
+        assert sg is not None
+        print("✓ StreamGrid initialization successful")
+        print("✓ All videos loaded correctly")
+        print("✓ YOLO model loaded successfully")
+    finally:
+        # Ensure background threads are cleaned up to avoid abort
+        if hasattr(sg, "stop"):
+            sg.stop()
+        if hasattr(sg, "close"):
+            sg.close()