Skip to content

Commit 28b8156

Browse files
authored
Tune ansible lint configuration (#374)
Let's run the github workflow to use a version of ansible-lint that is compatible to the official ansible-core version used by the project. Adjust yamllint configuration to what used by ansible. Lower fatal ansible-lint rules about roles path: it is something about the qe-sap-deployment structure that needs more works to be addressed.
1 parent 043e6db commit 28b8156

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

.ansible-lint

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ exclude_paths:
33
- ansible/playbooks/registration_role.yaml
44
- ansible/playbooks/vars/hana_media.yaml
55
- ansible/playbooks/vars/hana_vars.yaml
6+
warn_list:
7+
- role-name[path]

.github/workflows/ansible.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121
- name: Install all requirements
2222
run: |
2323
python3 -m pip install --upgrade -r requirements.txt
24-
python3 -m pip install ansible-lint==25.6.1
24+
# 25.1.3 is the newest version that support ansible-core 2.16.8 we are using right now
25+
python3 -m pip install ansible-lint==25.1.3
2526
ansible-galaxy install -r requirements.yml
2627
2728
- name: Run ansible static tests

.yamllint.yaml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
extends: default
22

33
rules:
4-
line-length: disable
4+
line-length: disable
5+
comments:
6+
min-spaces-from-content: 1
7+
comments-indentation: false
8+
braces:
9+
max-spaces-inside: 1
10+
octal-values:
11+
forbid-implicit-octal: false
12+
forbid-explicit-octal: true
13+

0 commit comments

Comments
 (0)