Remove pipelining from ansible.cfg

Pipelining is an Ansible optimization that sends the Python module script
over the existing SSH connection instead of creating a temporary file on the remote host.
Disabling it could make Ansible slightly slower but should henance the
robustness avoiding -13 SIGPIPE error.
Add ansible_common_remote_group: sapsys to tasks that become a non root user.

Author: mpagot

ansible.cfg

@@ -1,3 +1,2 @@
 [ssh_connection]
-pipelining = True
 ssh_args = -C -o ControlMaster=auto -o ControlPersist=86400s

ansible/roles/sap_hana_install/tasks/post_install/hdbuserstore.yml

@@ -1,7 +1,9 @@
 ---
 
 - name: SAP HANA Post Install - Create and Store Connection Info in hdbuserstore
-  ansible.builtin.shell: |
+  vars:
+    ansible_common_remote_group: sapsys
+  ansible.builtin.sh: |
       /usr/sap/{{ sap_hana_install_sid }}/SYS/exe/hdb/hdbuserstore \
       SET {{ sap_hana_install_hdbuserstore_key }} \
       {{ ansible_hostname }}:3{{ sap_hana_install_number }}13 \
@@ -10,6 +12,7 @@
     executable: /bin/bash
   become: true
   become_user: "{{ sap_hana_install_sid | lower }}adm"
+  common_remote_group: sapsys
   when: not ansible_check_mode
   changed_when: no
   register: __sap_hana_install_store_connection_information

scripts/qesap/lib/cmds.py

@@ -312,7 +312,7 @@ def ansible_command_sequence(
     # 1. Create the environment variable set
     #    that will be used by any command
     original_env = dict(os.environ)
-    original_env["ANSIBLE_PIPELINING"] = "True"
+    original_env["ANSIBLE_PIPELINING"] = "False"
     ansible_callbacks = []
     if profile:
         ansible_callbacks.append("ansible.posix.profile_tasks")

scripts/qesap/test/conftest.py

@@ -219,9 +219,6 @@ def _callback(inventory):
 def mock_call_ansibleplaybook():
     """
     create a mock.call with some default elements
-    ```
-    mock.call('ansible-playbook -i inventory, playbook', env={'ANSIBLE_PIPELINING', 'True'})
-    ```
     """
 
     def _callback(inventory, playbook, verbosity="-vv", arguments=None, env=None):
@@ -230,7 +227,7 @@ def _callback(inventory, playbook, verbosity="-vv", arguments=None, env=None):
             playbook_cmd += arguments
         if env is None:
             original_env = dict(os.environ)
-            original_env["ANSIBLE_PIPELINING"] = "True"
+            original_env["ANSIBLE_PIPELINING"] = "False"
         else:
             original_env = env
         return mock.call(cmd=' '.join(playbook_cmd), env=original_env)

scripts/qesap/test/unit/test_qesap_ansible.py

@@ -623,7 +623,7 @@ def test_ansible_env_config(
     # Keep it here just to be more explicit and due to the fact that here
     # the os.environ is mock.
     expected_env = {"MELAMPO": "cane"}
-    expected_env["ANSIBLE_PIPELINING"] = "True"
+    expected_env["ANSIBLE_PIPELINING"] = "False"
     for playbook in playbook_files_list:
         calls.append(mock_call_ansibleplaybook(inventory, playbook, env=expected_env))
 
@@ -668,7 +668,7 @@ def test_ansible_profile(
     playbook_files_list = create_playbooks(playbooks["create"])
     calls = []
     expected_env = {"MELAMPO": "cane"}
-    expected_env["ANSIBLE_PIPELINING"] = "True"
+    expected_env["ANSIBLE_PIPELINING"] = "False"
     expected_env["ANSIBLE_CALLBACKS_ENABLED"] = "ansible.posix.profile_tasks"
     for playbook in playbook_files_list:
         calls.append(mock_call_ansibleplaybook(inventory, playbook, env=expected_env))
@@ -717,7 +717,7 @@ def test_ansible_junit(
     playbook_files_list = create_playbooks(playbooks["create"])
     calls = []
     expected_env = {"MELAMPO": "cane"}
-    expected_env["ANSIBLE_PIPELINING"] = "True"
+    expected_env["ANSIBLE_PIPELINING"] = "False"
     expected_env["ANSIBLE_CALLBACKS_ENABLED"] = "junit"
     expected_env["JUNIT_OUTPUT_DIR"] = "/something/somewhere"
     for playbook in playbook_files_list:
@@ -772,7 +772,7 @@ def test_ansible_env_roles_path(
     playbook_files_list = create_playbooks(["get_cherry_wood"])
     calls = []
     expected_env = dict(os.environ)
-    expected_env["ANSIBLE_PIPELINING"] = "True"
+    expected_env["ANSIBLE_PIPELINING"] = "False"
     expected_env["ANSIBLE_ROLES_PATH"] = "somewhere"
     for playbook in playbook_files_list:
         calls.append(mock_call_ansibleplaybook(inventory, playbook, env=expected_env))