Fix generic Ansible lint warnings

Author: mpagot

ansible/playbooks/sap-hana-cluster.yaml

@@ -35,6 +35,18 @@
         state: started
         enabled: true
 
+    # When the stonith device is changed the file /var/lib/sbd is changed
+    - name: Write stonith status file
+      ansible.builtin.file:
+        path: "{{ item.path }}"
+        state: "{{ item.state }}"
+        owner: root
+        group: root
+        mode: '0700'
+      with_items:
+        - {'path': '/var/lib/qedep', 'state': 'directory'}
+        - {'path': '/var/lib/qedep/sbd', 'state': 'touch'}
+
   pre_tasks:
     - name: Detect cloud platform
       ansible.builtin.include_tasks:
@@ -90,6 +102,8 @@
           crm resource
           refresh
           {{ ms_saphanactl }}
+      register: refresh_ms_result
+      changed_when: refresh_ms_result.rc == 0
       when: is_primary
 
     - name: MS Resource Maintenance off
@@ -99,9 +113,12 @@
           maintenance
           {{ ms_saphanactl }}
           off
+      register: maintenance_off_result
+      changed_when: maintenance_off_result.rc == 0
       when: is_primary
 
     - name: Wait for cluster to settle
       ansible.builtin.command:
         cmd: cs_wait_for_idle -s 5
+      changed_when: false
       when: is_primary

ansible/playbooks/sap-hana-system-replication-hooks.yaml

@@ -1,12 +1,13 @@
 ---
-- hosts: hana
+- name: SAP Hana system replication hoks
+  hosts: hana
   remote_user: cloudadmin
   become: true
   become_user: root
 
   pre_tasks:
     - name: Source hana install variables
-      include_vars: ./vars/hana_vars.yaml
+      ansible.builtin.include_vars: ./vars/hana_vars.yaml
 
   vars:
     is_primary: "{{ ansible_play_hosts[0] == inventory_hostname }}"
@@ -26,6 +27,10 @@
           {{ __sapcontrol }}
           -nr {{ sap_hana_install_instance_number }}
           -function StopWait 600 10
+      register: stop_hana_result
+      changed_when:
+        - stop_hana_result.rc == 0
+        - "'OK' in stop_hana_result.stdout"
 
     - name: Start HANA Primary
       ansible.builtin.command:  # StartWait will timeout after 600 seconds.
@@ -34,6 +39,10 @@
           -nr {{ sap_hana_install_instance_number }}
           -function StartWait 600 10
       when: is_primary
+      register: start_hana_primary_result
+      changed_when:
+        - start_hana_primary_result.rc == 0
+        - "'OK' in start_hana_primary_result.stdout"
 
     - name: Start HANA Secondary
       ansible.builtin.command:  # StartWait will timeout after 600 seconds.
@@ -42,6 +51,10 @@
           -nr {{ sap_hana_install_instance_number }}
           -function StartWait 600 10
       when: not is_primary
+      register: start_hana_secondary_result
+      changed_when:
+        - start_hana_secondary_result.rc == 0
+        - "'OK' in start_hana_secondary_result.stdout"
 
   tasks:
     - name: Assert that required variables are defined

ansible/playbooks/tasks/aws-cluster-bootstrap.yaml

@@ -231,6 +231,8 @@
 - name: Enable SBD [sbd]
   ansible.builtin.command:
     cmd: crm configure primitive rsc_iscsi_sbd stonith:external/sbd
+  register: enable_sbd_result
+  changed_when: enable_sbd_result.rc == 0
   when:
     - sbd_stonith | string | lower  == 'false'
     - use_sbd | default(false) | bool
@@ -253,6 +255,7 @@
     - not (use_sbd | default(false) | bool)
     - ansible_distribution_major_version == '12'
   register: stonith_config_result
+  changed_when: stonith_config_result.rc == 0
   failed_when: >
     stonith_config_result.stderr_lines | select("match", "ERROR") | reject("match", "ERROR: warning") | list | length > 0
 
@@ -263,11 +266,14 @@
     - not (use_sbd | default(false) | bool)
     - ansible_distribution_major_version != '12'
   register: stonith_config_result
+  changed_when: stonith_config_result.rc == 0
   failed_when: "'ERROR' in stonith_config_result.stderr"
 
 - name: Set stonith-timeout [sdb]
   ansible.builtin.command:
     cmd: crm configure property stonith-timeout=144
+  register: set_stonith_timeout_sdb_result
+  changed_when: set_stonith_timeout_sdb_result.rc == 0
   when:
     - stonith_timeout != '144'
     - use_sbd | default(false) | bool
@@ -279,6 +285,8 @@
       crm configure property
       $id="cib-bootstrap-options"
       stonith-timeout=600s
+  register: set_stonith_timeout_aws_result
+  changed_when: set_stonith_timeout_aws_result.rc == 0
   when:
     - stonith_timeout != '600s'
     - is_primary
@@ -290,6 +298,8 @@
       crm configure property
       $id="cib-bootstrap-options"
       stonith-enabled=true
+  register: enable_stonith_result
+  changed_when: enable_stonith_result.rc == 0
   when:
     - stonith_enabled | string | lower != 'true'
     - is_primary
@@ -300,6 +310,8 @@
       crm configure property
       $id="cib-bootstrap-options"
       stonith-action=off
+  register: disable_stonith_action_result
+  changed_when: disable_stonith_action_result.rc == 0
   when:
     - stonith_action != 'off'
     - is_primary
@@ -314,6 +326,7 @@
     - resource_stickiness != '1000'
     - is_primary
   register: reg_rsc_defaults
+  changed_when: reg_rsc_defaults.rc == 0
   until: reg_rsc_defaults.rc == 0
   retries: 10
   delay: 10
@@ -324,13 +337,17 @@
       crm configure rsc_defaults
       $id="rsc-options"
       migration-threshold=5000
+  register: set_migration_threshold_result
+  changed_when: set_migration_threshold_result.rc == 0
   when:
     - migration_threshold != '5000'
     - is_primary
 
 - name: Set op_defaults timeout
   ansible.builtin.command:
     cmd: crm configure op_defaults timeout=600
+  register: set_op_defaults_timeout_result
+  changed_when: set_op_defaults_timeout_result.rc == 0
   when:
     - op_default_timeout != '600'
     - is_primary
@@ -348,6 +365,8 @@
       op start interval=0 timeout=180
       op stop interval=0 timeout=180
       op monitor interval=60 timeout=60
+  register: configure_cluster_ip_result
+  changed_when: configure_cluster_ip_result.rc == 0
   when:
     - rsc_ip | length == 0
     - is_primary
@@ -372,6 +391,7 @@
       rsc_ip_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}
       {{ primary_hostname }}
   register: reg_move_cmd
+  changed_when: reg_move_cmd.rc == 0
   when:
     - is_primary
     - reg_vip_location.stdout | trim | split(' ') | last != primary_hostname
@@ -385,6 +405,7 @@
       crm resource locate
       rsc_ip_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}
   register: reg_vip_location2
+  changed_when: false
   when:
     - is_primary
     - reg_vip_location.stdout | trim | split(' ') | last != primary_hostname

ansible/playbooks/tasks/gcp-cluster-bootstrap.yaml

@@ -339,6 +339,7 @@
     - resource_stickiness != '1000'
     - is_primary
   register: reg_rsc_defaults
+  changed_when: reg_rsc_defaults.rc == 0
   until: reg_rsc_defaults.rc == 0
   retries: 10
   delay: 10
@@ -400,6 +401,7 @@
       rsc_ip_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}
       {{ primary_hostname }}
   register: reg_move_cmd
+  changed_when: reg_move_cmd.rc == 0
   when:
     - is_primary
     - reg_vip_location.stdout | trim | split(' ') | last != primary_hostname
@@ -413,6 +415,7 @@
       crm resource locate
       rsc_ip_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}
   register: reg_vip_location2
+  changed_when: false
   when:
     - is_primary
     - reg_vip_location.stdout | trim | split(' ') | last != primary_hostname

ansible/playbooks/tasks/rebuild-stonith.yaml

@@ -20,11 +20,14 @@
   ansible.builtin.command:
     cmd: "crm resource stop {{ sbd_device_name }}"
   register: sbd_status
+  changed_when: true
   when: sbd_device_status == 'Started' or sbd_device_status == 'running'
 
 - name: Remove stonith device
   ansible.builtin.command:
     cmd: "crm configure delete {{ sbd_device_name }}"
+  register: remove_stonith_result
+  changed_when: remove_stonith_result.rc == 0
   when: sbd_device_name != 'NOresourcesconfigured'  # If no stonith was found 'NOresourcesconfigured' should be registered in {{ sbd_device_name }}
 
 - name: Create new SBD stonith device
@@ -38,16 +41,5 @@
       pcmk_delay_max="15"
       op monitor interval="600" timeout="15"
   register: create_stonith
-
-  # When the stonith device is changed the file /var/lib/sbd is changed
-- name: Write status file
-  ansible.builtin.file:
-    path: "{{ item.path }}"
-    state: "{{ item.state }}"
-    owner: root
-    group: root
-    mode: '0700'
-  when: create_stonith.changed
-  with_items:
-    - {'path': '/var/lib/qedep', 'state': 'directory'}
-    - {'path': '/var/lib/qedep/sbd', 'state': 'touch'}
+  changed_when: create_stonith.rc == 0
+  notify: Write stonith status file