Skip to content

Commit e6e95a4

Browse files
authored
Fix bug that prevent softfail for guestregister (#446)
Fix task order to allow all tasks to be executed.
1 parent 797be14 commit e6e95a4

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

ansible/playbooks/tasks/check-guestregister-service.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,6 @@
224224
- "Lock Error Found: {{ lock_error_log_line | default('None found') }}"
225225
- "Culprit PID History: {{ pid_history.stdout_lines | default('No history found') }}"
226226

227-
- name: Fail if guestregister.service is not in the expected state
228-
ansible.builtin.assert:
229-
that: false
230-
fail_msg: "FATAL: guestregister.service is not in the expected state (inactive/success) after retries. Check logs above for details."
231-
232227
# [RECOVERY] Attempting to fix the transient failure (e.g. race condition)
233228
- name: Attempt proactive restart for recovery verification
234229
ansible.builtin.systemd:
@@ -248,7 +243,7 @@
248243
- name: Check for registration
249244
ansible.builtin.command: SUSEConnect -s
250245
register: recovery_reg_stat
251-
until: recovery_reg_stats.rc == 0
246+
until: recovery_reg_stat.rc == 0
252247
retries: 5
253248
delay: 120
254249
failed_when: recovery_reg_stat.rc != 0
@@ -264,3 +259,8 @@
264259
ansible.builtin.debug:
265260
msg:
266261
- "[OSADO][softfail] bsc#1254984"
262+
263+
- name: Fail if guestregister.service is not in the expected state
264+
ansible.builtin.assert:
265+
that: false
266+
fail_msg: "FATAL: guestregister.service is not in the expected state (inactive/success) after retries. Check logs above for details."

0 commit comments

Comments
 (0)