Commit 72a4fa3
committed
Fix numa_allocator test failure on macOS
The test tests.unit.modules.compute_local.numa_allocator was failing on
macOS due to two issues:
1. topology::get_numa_domain() was throwing an exception when
hwloc_get_area_memlocation() failed, which is not supported on macOS.
Fixed by adding macOS to the platforms that return 0 as a fallback
(similar to FreeBSD).
2. numa_binding_allocator::get_page_numa_domains() was returning an empty
string on non-Linux platforms, causing the test assertion to fail.
Fixed by implementing a fallback that returns a string with all zeros,
assuming a single NUMA domain (which is typical for macOS systems).
This ensures the test passes on macOS while maintaining the existing
behavior on Linux and other platforms.1 parent feed1d5 commit 72a4fa3
2 files changed
Lines changed: 13 additions & 3 deletions
File tree
- libs/core
- compute_local/include/hpx/compute_local/host
- topology/src
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
435 | | - | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
436 | 446 | | |
437 | 447 | | |
438 | 448 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1416 | 1416 | | |
1417 | 1417 | | |
1418 | 1418 | | |
1419 | | - | |
1420 | | - | |
| 1419 | + | |
| 1420 | + | |
1421 | 1421 | | |
1422 | 1422 | | |
1423 | 1423 | | |
| |||
0 commit comments