Converting third-party applets for Wayland

[fossfreedom]

This issue is to track those third-party applets we currently package in backports

At a minimum for the first offering we will need to have stub packages in the wayland PPA to prevent v1 vs v2 issues

Where we don't actively maintain these ourselves, lets offer the maintainer a PR to resolve - often a meson option or similar to allow compilation against v1 vs v2.

• budgie-analogue-clock-applet - packaged for wayland PPA
• budgie-browser-profile-launcher - uses popover.resize and popover.set_default_size that need replacing (worked fine when switched to using set_size_request)
• budgie-calendar-applet - Tested working
• budgie-carbon-tray-applet  - This is unlikely since xembed to X specific. so lets just stub this package
• budgie-clipboard-applet  - Tested working - retested - sometimes doesn't paste into an app - have to switch between windows. Uploaded anyway since it mostly works
• budgie-cpufreq-applet - Tested working - we'll need to patch ourselves since their is no longer a working upstream
• budgie-cputemp-applet - Tested working
• budgie-lightpad-applet - this covers both the applet and the main lightpad app. - Main app v0.8 does not work, applet itself does work gitmaster now works
• budgie-media-player-applet - Tested working
• budgie-performance-gauge-applet - Tested working
• budgie-pixel-saver-applet - doubtful since I think this I think has X specific bits, but lets test anyway. - Tested but does not work (uses wnck)
• budgie-sys-monitor-applet - Tested working - we'll need to patch ourselves since their is no longer a working upstream
• budgie-user-indicator-redux-applet - Tested working
• indicator-sysmonitor - Update plugin to python

[samlane-ma]

looking at lightpad (main app)

not working as-is:

(com.github.libredeb.lightpad:4229): Gdk-CRITICAL **: 18:39:18.362: gdk_monitor_get_geometry: assertion 'GDK_IS_MONITOR (monitor)' failed
** Message: 18:39:18.362: Application.vala:66: The monitor dimensions are: 0x0
(com.github.libredeb.lightpad:4229): Gdk-WARNING **: 18:39:18.477: Native Windows wider than 65535 pixels are not supported
(com.github.libredeb.lightpad:4229): Gdk-CRITICAL **: 18:39:18.492: ../../../gdk/wayland/gdkdisplay-wayland.c:1433: Unable to create Cairo image surface: invalid value (typically too big) for the size of the input (surface, pattern, etc.)
Segmentation fault (core dumped)

Main app in git still uses code known not to work under Wayland. i.e.
https://github.com/libredeb/lightpad/blob/f31e0e06dabd8d2d7562706d5ff333723180685d/src/Application.vala#L91

[samlane-ma]

Browser profile launcher applet uses popover.resize and popover.set_default_size, which would need to be replaced to be functional, but will work otherwise

[fossfreedom]

looking at lightpad (main app)

not working as-is:

(com.github.libredeb.lightpad:4229): Gdk-CRITICAL **: 18:39:18.362: gdk_monitor_get_geometry: assertion 'GDK_IS_MONITOR (monitor)' failed
** Message: 18:39:18.362: Application.vala:66: The monitor dimensions are: 0x0
(com.github.libredeb.lightpad:4229): Gdk-WARNING **: 18:39:18.477: Native Windows wider than 65535 pixels are not supported
(com.github.libredeb.lightpad:4229): Gdk-CRITICAL **: 18:39:18.492: ../../../gdk/wayland/gdkdisplay-wayland.c:1433: Unable to create Cairo image surface: invalid value (typically too big) for the size of the input (surface, pattern, etc.)
Segmentation fault (core dumped)

Main app in git still uses code known not to work under Wayland. i.e. https://github.com/libredeb/lightpad/blob/f31e0e06dabd8d2d7562706d5ff333723180685d/src/Application.vala#L91

Fixed this and PRd upstream. Gitmaster now works

[fossfreedom]

lightpad v0.0.9 built in backports. v0.0.3 budgie-lightpad-applet built with ABI bump in wayland-test PPA

[fossfreedom]

uploaded upstreams version of the redux applet with upstream patch for libpeas. Marked as ready.
Unticked the analogue applet since needs tweaks.

[fossfreedom]

@samlane-ma FYI

re

budgie-cpufreq-applet - Tested working - we'll need to patch ourselves since their is no longer a working upstream

I've forked the (what was) upstream repo for this here https://github.com/UbuntuBudgie/budgie-cpufreq-applet

On the latest commit I've done a rough conversion to libpeas 2 and to have multi-arch support <-- the latter point various parts of the applet was hardcoded to the /usr/lib/budgie-desktop/plugins location.

Obviously needs testing etc.

[fossfreedom]

bumped to v1.1.0 for cpufreq and uploaded

uploaded v2.2 for budgie-analogue-clock-applet

[fossfreedom]

patched budgie-sys-monitor applet uploaded

[fossfreedom]

patched budgie-performance-monitor applet - the upstream seems to have disappeared.

Also PRd changes for budgie-media-player-applet - this is now packaged in the PPA

budgie-cpufreq-applet and budgie-cputemp-applet patched and uploaded

[fossfreedom]

indicator-sysmonitor patched for the .plugin change as well as Budgie-1.0 --> Budgie-2.0