Add sub tests

Author: stevenfontanella

src/gen-s-parser.inc

@@ -4102,12 +4102,23 @@ switch (buf[0]) {
                       default: goto parse_error;
                     }
                   }
-                  case 'u':
-                    if (op == "i64.sub"sv) {
-                      CHECK_ERR(makeBinary(ctx, pos, annotations, BinaryOp::SubInt64));
-                      return Ok{};
+                  case 'u': {
+                    switch (buf[7]) {
+                      case '\0':
+                        if (op == "i64.sub"sv) {
+                          CHECK_ERR(makeBinary(ctx, pos, annotations, BinaryOp::SubInt64));
+                          return Ok{};
+                        }
+                        goto parse_error;
+                      case '1':
+                        if (op == "i64.sub128"sv) {
+                          CHECK_ERR(makeWideIntAddSub(ctx, pos, annotations, WideIntAddSubOp::SubInt128));
+                          return Ok{};
+                        }
+                        goto parse_error;
+                      default: goto parse_error;
                     }
-                    goto parse_error;
+                  }
                   default: goto parse_error;
                 }
               }

test/spec/wide-arithmetic.wast

@@ -1,3 +1,4 @@
+;;; --enable-wide-arithmetic
 (module
   (func (export "i64.add128") (param i64 i64 i64 i64) (result i64 i64)
     local.get 0
@@ -113,6 +114,28 @@
                    (i64.const 1) (i64.const 0))
                (i64.const 414720966820876429) (i64.const -1))
 
+;; simple subtraction
+(assert_return (invoke "i64.sub128"
+                  (i64.const 0) (i64.const 0)
+                  (i64.const 0) (i64.const 0))
+               (i64.const 0) (i64.const 0))
+(assert_return (invoke "i64.sub128"
+                  (i64.const 1) (i64.const 0)
+                  (i64.const 1) (i64.const 0))
+               (i64.const 0) (i64.const 0))
+(assert_return (invoke "i64.sub128"
+                  (i64.const 0) (i64.const 0)
+                  (i64.const 1) (i64.const 0))
+               (i64.const 0xffffffffffffffff) (i64.const 0xffffffffffffffff))
+(assert_return (invoke "i64.sub128"
+                  (i64.const 0) (i64.const 1)
+                  (i64.const 1) (i64.const 0))
+               (i64.const 0xffffffffffffffff) (i64.const 0))
+(assert_return (invoke "i64.sub128"
+                  (i64.const 1) (i64.const 2)
+                  (i64.const 3) (i64.const 4))
+               (i64.const 0xfffffffffffffffe) (i64.const 0xfffffffffffffffd))
+
 ;; assert overlong encodings for each instruction's binary encoding are accepted
 (module binary
   "\00asm" "\01\00\00\00"
@@ -171,24 +194,71 @@
   )
   "type mismatch")
 
-;; simple subtraction
-(assert_return (invoke "i64.sub128"
-                  (i64.const 0) (i64.const 0)
-                  (i64.const 0) (i64.const 0))
-               (i64.const 0) (i64.const 0))
-(assert_return (invoke "i64.sub128"
-                  (i64.const 1) (i64.const 0)
-                  (i64.const 1) (i64.const 0))
-               (i64.const 0) (i64.const 0))
-(assert_return (invoke "i64.sub128"
-                  (i64.const 0) (i64.const 0)
-                  (i64.const 1) (i64.const 0))
-               (i64.const 0xffffffffffffffff) (i64.const 0xffffffffffffffff))
-(assert_return (invoke "i64.sub128"
-                  (i64.const 0) (i64.const 1)
-                  (i64.const 1) (i64.const 0))
-               (i64.const 0xffffffffffffffff) (i64.const 0))
-(assert_return (invoke "i64.sub128"
+(assert_invalid
+  (module
+    (func (param i64 i64 i64 i64) (result i64)
+      local.get 0
+      local.get 1
+      local.get 2
+      local.get 3
+      i64.sub128)
+  )
+  "type mismatch")
+(assert_invalid
+  (module
+    (func (param i64 i64 i64) (result i64 i64)
+      local.get 0
+      local.get 1
+      local.get 2
+      i64.sub128)
+  )
+  "type mismatch")
+
+(module binary
+  "\00asm" "\01\00\00\00"
+
+  "\01\0a"                  ;; type section, 10 bytes
+  "\01"                     ;; 1 count
+  "\60"                     ;; type0 = function
+  "\04\7e\7e\7e\7e"         ;;  4 params - all i64
+  "\02\7e\7e"               ;;  2 results - both i64
+
+  "\03\03"                  ;; function section, 3 byte
+  "\02"                     ;; 2 count
+  "\00\00"                  ;; types of each function (0, 0)
+
+  "\07\1b"                  ;; export section 0x1b bytes
+  "\02"                     ;; 2 count
+  "\0ai64.add128\00\00"     ;; "i64.add128" which is function 0
+  "\0ai64.sub128\00\01"     ;; "i64.sub128" which is function 1
+
+  "\0a\1e"                  ;; code section + byte length
+  "\02"                     ;; 2 count
+
+  "\0e"                     ;; byte length
+  "\00"                     ;; no locals
+  "\20\00"                  ;; local.get 0
+  "\20\01"                  ;; local.get 1
+  "\20\02"                  ;; local.get 2
+  "\20\03"                  ;; local.get 3
+  "\fc\93\80\00"            ;; i64.add128 (overlong)
+  "\0b"                     ;; end
+
+  "\0d"                     ;; byte length
+  "\00"                     ;; no locals
+  "\20\00"                  ;; local.get 0
+  "\20\01"                  ;; local.get 1
+  "\20\02"                  ;; local.get 2
+  "\20\03"                  ;; local.get 3
+  "\fc\94\00"               ;; i64.sub128 (overlong)
+  "\0b"                     ;; end
+)
+
+(assert_return (invoke "i64.add128"
                   (i64.const 1) (i64.const 2)
                   (i64.const 3) (i64.const 4))
-               (i64.const 0xfffffffffffffffe) (i64.const 0xfffffffffffffffd))
+               (i64.const 4) (i64.const 6))
+(assert_return (invoke "i64.sub128"
+                  (i64.const 2) (i64.const 5)
+                  (i64.const 1) (i64.const 2))
+               (i64.const 1) (i64.const 3))