Review comments

Author: saulecabrera

tests/rust/wasm32-wasip3/src/bin/sockets-udp-bind.rs

@@ -62,9 +62,9 @@ fn test_ephemeral_port_assignment(family: IpAddressFamily) {
     assert_ne!(addr.port(), bound.port());
 }
 
-fn test_dual_stack_support() {
+fn test_reject_dual_stack() {
     let sock = UdpSocket::create(IpAddressFamily::Ipv6).unwrap();
-    let addr = IpSocketAddress::ipv6_mapped_localhost(0);
+    let addr = IpSocketAddress::ipv4_mapped_ipv6_localhost(0);
     let result = sock.bind(addr);
 
     assert!(matches!(result, Err(ErrorCode::InvalidArgument)));
@@ -88,7 +88,7 @@ impl Guest for Component {
         test_not_bindable(IpAddressFamily::Ipv6);
         test_ephemeral_port_assignment(IpAddressFamily::Ipv4);
         test_ephemeral_port_assignment(IpAddressFamily::Ipv6);
-        test_dual_stack_support();
+        test_reject_dual_stack();
         test_unspecified_addr(IpAddressFamily::Ipv4);
         test_unspecified_addr(IpAddressFamily::Ipv6);
 

tests/rust/wasm32-wasip3/src/bin/sockets-udp-connect.rs

@@ -21,9 +21,9 @@ fn test_invalid_address_family(family: IpAddressFamily) {
     assert!(matches!(result, Err(ErrorCode::InvalidArgument)));
 }
 
-fn test_dual_stack_support() {
+fn test_reject_dual_stack() {
     let sock = UdpSocket::create(IpAddressFamily::Ipv6).unwrap();
-    let addr = IpSocketAddress::ipv6_mapped_localhost(PORT);
+    let addr = IpSocketAddress::ipv4_mapped_ipv6_localhost(PORT);
     let result = sock.connect(addr);
 
     assert!(matches!(result, Err(ErrorCode::InvalidArgument)));
@@ -111,7 +111,7 @@ impl Guest for Component {
         test_invalid_address_family(IpAddressFamily::Ipv4);
         test_invalid_address_family(IpAddressFamily::Ipv6);
 
-        test_dual_stack_support();
+        test_reject_dual_stack();
 
         test_unspecified_remote_addr(IpAddressFamily::Ipv4);
         test_unspecified_remote_addr(IpAddressFamily::Ipv6);

tests/rust/wasm32-wasip3/src/bin/sockets-udp-send.rs

@@ -52,7 +52,7 @@ async fn test_connected_with_addr(family: IpAddressFamily) {
         Err(ErrorCode::InvalidArgument)
     );
 
-    assert!(sock.send(vec![0; 1], Some(remote_addr)).await.is_ok());
+    sock.send(vec![0; 1], Some(remote_addr)).await.unwrap();
 }
 
 async fn test_not_connected_empty_addr(family: IpAddressFamily) {
@@ -70,7 +70,7 @@ async fn test_unspecified_remote_addr(family: IpAddressFamily) {
     // FIXME: According to the spec this should return
     //     `invalid-argument`: The IP address in `remote-address` is
     //     set to INADDR_ANY (`0.0.0.0` / `::`).
-    assert!(matches!(result, Err(ErrorCode::RemoteUnreachable)));
+    assert!(matches!(result, Err(ErrorCode::InvalidArgument)));
 }
 
 async fn test_remote_addr_with_port_0(family: IpAddressFamily) {