Feature: Add support to search within multiple organisational units in ldap#535
Open
nicoklaus wants to merge 2 commits into
Open
Feature: Add support to search within multiple organisational units in ldap#535nicoklaus wants to merge 2 commits into
nicoklaus wants to merge 2 commits into
Conversation
Signed-off-by: Nicolas <32845761+nicoklaus@users.noreply.github.com>
Signed-off-by: Nicolas <32845761+nicoklaus@users.noreply.github.com>
Contributor
|
Hey @nicoklaus, nice feature. A few suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Changes
This change adds support for searching users across multiple LDAP locations instead of only a single base DN. A new
AUTH_LDAP_USER_SEARCHESsetting allows multiple LDAP search definitions to be provided as a JSON list. The code validates the configuration, creates multipleLDAPSearchobjects, and combines them usingLDAPSearchUnion. If the new setting is not configured, the existing single-search behavior remains unchanged for backward compatibility. This is needed for environments where users are stored in different OUs or LDAP directory structures.Checklist