From 0286168fc6e07a6ea02eff1f3d6702aa5a11ebd4 Mon Sep 17 00:00:00 2001
From: jaogoy <jaogoy@gmail.com>
Date: Mon, 26 Jan 2026 10:51:57 +0800
Subject: [PATCH] feat(starrocks)!: support setting http or https for data
 loading url

Users can directly set the scheme to http or https in the starrocks
configuration.
Default: it will use http if users haven't specify the scheme for the
data loading url.

Signed-off-by: jaogoy <jaogoy@gmail.com>
---
 .../manager/StarRocksStreamLoadVisitor.java   | 29 +++++++++++++++----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/starrockswriter/src/main/java/com/starrocks/connector/datax/plugin/writer/starrockswriter/manager/StarRocksStreamLoadVisitor.java b/starrockswriter/src/main/java/com/starrocks/connector/datax/plugin/writer/starrockswriter/manager/StarRocksStreamLoadVisitor.java
index b3671556a2..ce9b1d0351 100644
--- a/starrockswriter/src/main/java/com/starrocks/connector/datax/plugin/writer/starrockswriter/manager/StarRocksStreamLoadVisitor.java
+++ b/starrockswriter/src/main/java/com/starrocks/connector/datax/plugin/writer/starrockswriter/manager/StarRocksStreamLoadVisitor.java
@@ -31,7 +31,7 @@
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
- 
+
 public class StarRocksStreamLoadVisitor {
 
     private static final Logger LOG = LoggerFactory.getLogger(StarRocksStreamLoadVisitor.class);
@@ -104,7 +104,8 @@ private String getAvailableHost() {
         List<String> hostList = writerOptions.getLoadUrlList();
         long tmp = pos + hostList.size();
         for (; pos < tmp; pos++) {
-            String host = new StringBuilder("http://").append(hostList.get((int) (pos % hostList.size()))).toString();
+            String rawHost = hostList.get((int) (pos % hostList.size()));
+            String host = normalizeHostScheme(rawHost);
             if (tryHttpConnection(host)) {
                 return host;
             }
@@ -112,8 +113,26 @@ private String getAvailableHost() {
         return null;
     }
 
+    private String normalizeHostScheme(String host) {
+        if (host == null) {
+            return null;
+        }
+        String trimmed = host.trim();
+        if (trimmed.isEmpty()) {
+            return trimmed;
+        }
+        if (hasScheme(trimmed)) {
+            return trimmed;
+        }
+        return "http://" + trimmed;
+    }
+
+    private boolean hasScheme(String host) {
+        return host.matches("^[a-zA-Z][a-zA-Z0-9+\\-.]*://.*");
+    }
+
     private boolean tryHttpConnection(String host) {
-        try {  
+        try {
             URL url = new URL(host);
             HttpURLConnection co =  (HttpURLConnection) url.openConnection();
             co.setConnectTimeout(1000);
@@ -137,7 +156,7 @@ private byte[] joinRows(List<byte[]> rows, int totalBytes) {
             }
             return bos.array();
         }
-       
+
         if (StarRocksWriterOptions.StreamLoadFormat.JSON.equals(writerOptions.getStreamLoadFormat())) {
             ByteBuffer bos = ByteBuffer.allocate(totalBytes + (rows.isEmpty() ? 2 : rows.size() + 1));
             bos.put("[".getBytes(StandardCharsets.UTF_8));
@@ -274,7 +293,7 @@ private HttpEntity getHttpEntity(CloseableHttpResponse resp) {
         }
         return respEntity;
     }
-	
+
     private String doHttpGet(String getUrl) throws IOException {
         LOG.info("Executing GET from {}.", getUrl);
         try (CloseableHttpClient httpclient = buildHttpClient()) {