fix: fix incorrect splitting with line delimited streaming#700
Merged
Conversation
bboissin
force-pushed
the
push-kqpokpnqwusw
branch
from
eb82fdc to
f37ccf8
Compare
crepererum
reviewed
Apr 27, 2026
In some cases, valid CSV in datafusion would return:
`Generic { store: "LineDelimiter", source: UnterminatedString }` due to incorrect logic.
records_ends is a double ended iterator, so when calling next_back() the
quoting/escaping logic would run in reverse, corrupting the internal state.
bboissin
force-pushed
the
push-kqpokpnqwusw
branch
from
f37ccf8 to
36af88f
Compare
crepererum
approved these changes
Apr 28, 2026
tustvold
approved these changes
Jun 2, 2026
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Thank you for this, added a small tweak to use .last instead of collecting into a vec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, valid CSV in datafusion would return:
Generic { store: "LineDelimiter", source: UnterminatedString }due to incorrect logic.records_ends is a double ended iterator, so when calling next_back() the quoting/escaping logic would run in reverse, corrupting the internal state.
Which issue does this PR close?
Closes #650