From 7f8310713569aab80bad6e13599b885eea92c03d Mon Sep 17 00:00:00 2001 From: Shunping Huang Date: Sun, 10 May 2026 21:09:32 -0400 Subject: [PATCH 1/3] Remove ValidatesRunner from testMetadataPropagationParameter --- .../org/apache/beam/sdk/transforms/MetadataPropagationTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java index 72f914caf31e..51d970ec4b42 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java @@ -81,7 +81,7 @@ public void testMetadataPropagationAcrossShuffleParameter() { } @Test - @Category({ValidatesRunner.class, NeedsRunner.class}) + @Category(NeedsRunner.class) public void testMetadataPropagationParameter() { WindowedValues.WindowedValueCoder.setMetadataSupported(); PCollection results = From efad38862b58021a09b7cb1d92580233117fde74 Mon Sep 17 00:00:00 2001 From: Shunping Huang Date: Sun, 10 May 2026 21:15:58 -0400 Subject: [PATCH 2/3] Add comments. --- .../apache/beam/sdk/transforms/MetadataPropagationTest.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java index 51d970ec4b42..a1cee483d858 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java @@ -80,6 +80,11 @@ public void testMetadataPropagationAcrossShuffleParameter() { pipeline.run(); } + /** + * Tests metadata propagation for a parameter. Note: PAssert internally introduces a GroupByKey. + * This test works only with DirectRunner and runners that support metadata propagation. + * See {@link #testMetadataPropagationAcrossGBK} for more information. + */ @Test @Category(NeedsRunner.class) public void testMetadataPropagationParameter() { From 8333b5b72393f6e27e8a88d8049670e2cc81d6f7 Mon Sep 17 00:00:00 2001 From: Shunping Huang Date: Sun, 10 May 2026 21:33:36 -0400 Subject: [PATCH 3/3] Apply Spotless --- .../apache/beam/sdk/transforms/MetadataPropagationTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java index a1cee483d858..3e5ff77cb1c4 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java @@ -22,7 +22,6 @@ import org.apache.beam.sdk.testing.PAssert; import org.apache.beam.sdk.testing.TestPipeline; import org.apache.beam.sdk.testing.TestStream; -import org.apache.beam.sdk.testing.ValidatesRunner; import org.apache.beam.sdk.transforms.windowing.FixedWindows; import org.apache.beam.sdk.transforms.windowing.IntervalWindow; import org.apache.beam.sdk.transforms.windowing.Window; @@ -82,8 +81,8 @@ public void testMetadataPropagationAcrossShuffleParameter() { /** * Tests metadata propagation for a parameter. Note: PAssert internally introduces a GroupByKey. - * This test works only with DirectRunner and runners that support metadata propagation. - * See {@link #testMetadataPropagationAcrossGBK} for more information. + * This test works only with DirectRunner and runners that support metadata propagation across + * GroupByKey. See {@link #testMetadataPropagationAcrossGBK} for more information. */ @Test @Category(NeedsRunner.class)