Commit c82c42e
authored
feat(datafusion): show pushed-down limit in IcebergTableScan EXPLAIN output (#2360)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #2359.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
Emit ` limit:[N]` in `IcebergTableScan`'s `DisplayAs` output when a
`LIMIT` is pushed down to the scan. When no limit is pushed down, the
output is unchanged.
- Before (unchanged):
`IcebergTableScan projection:[id,name] predicate:[...]`
- After (new, only when a limit reaches the scan):
`IcebergTableScan projection:[...] predicate:[] limit:[3]`
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes: new `EXPLAIN ... LIMIT 3` assertion in
`crates/sqllogictest/testdata/slts/df_test/basic_queries.slt`. Existing
snapshots are unchanged, which confirms the additive-only behavior.1 parent 4b4ffd0 commit c82c42e
2 files changed
Lines changed: 17 additions & 1 deletion
File tree
- crates
- integrations/datafusion/src/physical_plan
- sqllogictest/testdata/slts/df_test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
200 | 204 | | |
201 | 205 | | |
202 | 206 | | |
| |||
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
46 | 58 | | |
47 | 59 | | |
48 | 60 | | |
| |||
0 commit comments