Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties#16186
Merged
kevinjqliu merged 2 commits intoapache:mainfrom May 8, 2026
Merged
Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties#16186kevinjqliu merged 2 commits intoapache:mainfrom
kevinjqliu merged 2 commits intoapache:mainfrom
Conversation
huaxingao
reviewed
May 1, 2026
| properties.getOrDefault( | ||
| AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM, | ||
| KeyWrapAlgorithm.RSA_OAEP_256.getValue()); | ||
| properties.getOrDefault(AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM, "RSA-OAEP-256"); |
Contributor
There was a problem hiding this comment.
Could we extract this into a named constant with a comment noting which Azure SDK value it mirrors? Something like:
> // Must match KeyWrapAlgorithm.RSA_OAEP_256.getValue() from azure-security-keyvault-keys
> private static final String DEFAULT_KEY_WRAP_ALGORITHM = "RSA-OAEP-256";
>
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion, updated.
singhpk234
reviewed
May 1, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
The refactor make sense to me in general since this is the compile time dependency in iceberg-azure, though i am curious its implementation of iceberg-azure-bundle does trino doesn't depends on the bundle ?
Member
Author
|
@singhpk234 Trino Iceberg connecrtor doesn't use iceberg-azure module. It leads to a build failure with Maven duplicate-finder plugin. |
stevenzwu
approved these changes
May 8, 2026
aihuaxu
approved these changes
May 8, 2026
nandorKollar
approved these changes
May 8, 2026
kevinjqliu
approved these changes
May 8, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Great find, thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, any downstream application that uses AzureProperties will encounter a NoClassDefFound error even if table encryption is unused.
Changing the return type is safe because Iceberg 1.10.x does not include #13186