fix(CI): Enable CI run success on Mac OS, change C++ standard based on Apache-Arrow version

Author: SYaoJun

.github/workflows/ci.yml

@@ -201,6 +201,7 @@ jobs:
       run: |
         brew bundle --file=cpp/Brewfile
         git clone https://github.com/apache/incubator-graphar-testing.git $GAR_TEST_DATA --depth 1
+        brew list --versions
 
     - name: Build GraphAr
       working-directory: "cpp"

cpp/CMakeLists.txt

@@ -104,11 +104,13 @@ if(NOT (CMAKE_CXX_COMPILER_LAUNCHER MATCHES "ccache") AND NOT (CMAKE_C_COMPILER_
     endif(ccache_EXECUTABLE)
 endif()
 
+set(GAR_CXX_STANDARD 17)
+
 if(MSVC)
     # Avoid GCC/Clang-specific flags on MSVC.
     # C++17 is already enforced via CMAKE_CXX_STANDARD/target features.
 else()
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -Wall -Werror=unused-variable")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror=unused-variable")
 endif()
 
 if (APPLE)
@@ -147,7 +149,6 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake)
 include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 add_library(${PROJECT_NAME} INTERFACE)
-target_compile_features(${PROJECT_NAME} INTERFACE cxx_std_17)
 target_include_directories(
     ${PROJECT_NAME}
     INTERFACE
@@ -295,7 +296,7 @@ macro(build_graphar)
         add_library(graphar SHARED ${CORE_SRC_FILES})
     endif()
     install_graphar_target(graphar)
-    target_compile_features(graphar PRIVATE cxx_std_17)
+    target_compile_features(graphar PRIVATE cxx_std_${GAR_CXX_STANDARD})
     target_include_directories(graphar PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/thirdparty)
     target_link_libraries(graphar PRIVATE ${CMAKE_DL_LIBS})
 
@@ -352,7 +353,7 @@ macro(build_graphar_with_arrow_bundled)
         add_library(graphar SHARED ${CORE_SRC_FILES})
     endif()
     install_graphar_target(graphar)
-    target_compile_features(graphar PRIVATE cxx_std_17)
+    target_compile_features(graphar PRIVATE cxx_std_${GAR_CXX_STANDARD})
     target_include_directories(graphar PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/thirdparty)
     target_include_directories(graphar SYSTEM BEFORE PRIVATE ${GAR_ARROW_INCLUDE_DIR})
     target_link_libraries(graphar PRIVATE ${CMAKE_DL_LIBS})
@@ -426,7 +427,13 @@ if (BUILD_ARROW_FROM_SOURCE)
         endif()
     endif()
     find_package(CURL REQUIRED)
-
+    if(DEFINED ENV{GRAPHAR_ARROW_VERSION})
+        if ($ENV{GRAPHAR_ARROW_VERSION} VERSION_GREATER_EQUAL "23.0.0")
+            set(GAR_CXX_STANDARD 20)
+        endif()
+    else()
+        set(GAR_CXX_STANDARD 20) # Default Arrow version is 23.0.0 need C++20
+    endif()
     include(apache-arrow)
     build_arrow()
     add_definitions(-DARROW_ORC) # Add macro, otherwise inconsistent in build phase with not from source.
@@ -460,9 +467,17 @@ else()
         message(FATAL_ERROR "parquet is required, please install it and retry")
     endif()
 
+    # Update C++ standard based on detected system Arrow version
+    if (Arrow_VERSION VERSION_GREATER_EQUAL "23.0.0")
+        set(GAR_CXX_STANDARD 20)
+        message(STATUS "Arrow ${Arrow_VERSION} detected")
+    endif()
+
     build_graphar()
 endif()
 
+message(STATUS "[graphar] using C++ standard: ${GAR_CXX_STANDARD}")
+
 # ------------------------------------------------------------------------------
 # build examples
 # ------------------------------------------------------------------------------
@@ -564,7 +579,7 @@ if (BUILD_TESTS)
         set(multiValueArgs SRCS)
         cmake_parse_arguments(add_test "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
         add_executable(${target} ${add_test_SRCS})
-        target_compile_features(${target} PRIVATE cxx_std_17)
+        target_compile_features(${target} PRIVATE cxx_std_${GAR_CXX_STANDARD})
         target_include_directories(${target} PRIVATE ${PROJECT_SOURCE_DIR}/thirdparty)
         target_link_libraries(${target} PRIVATE Catch2::Catch2WithMain graphar ${CMAKE_DL_LIBS})
         if (BUILD_ARROW_FROM_SOURCE)
@@ -630,7 +645,7 @@ if (BUILD_BENCHMARKS)
         set(multiValueArgs SRCS)
         cmake_parse_arguments(add_test "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
         add_executable(${target} ${add_test_SRCS})
-        target_compile_features(${target} PRIVATE cxx_std_17)
+        target_compile_features(${target} PRIVATE cxx_std_${GAR_CXX_STANDARD})
         target_include_directories(${target} PRIVATE ${PROJECT_SOURCE_DIR}/thirdparty)
         target_link_libraries(${target} PRIVATE benchmark::benchmark_main graphar ${CMAKE_DL_LIBS})
         if (BUILD_ARROW_FROM_SOURCE)