refactor

Author: empiredan

src/http/http_server.h

@@ -82,9 +82,10 @@ struct http_response
         as_bad_request(fmt::format("{} should not be empty", key));
     }
 
-    void set_json_body(std::string str)
+    void as_ok_json(std::string str)
     {
         body = std::move(str);
+        status_code = http_status_code::kOk;
         content_type = "application/json; charset=utf-8";
     }
 

src/replica/replica_http_service.cpp

@@ -120,8 +120,7 @@ void replica_http_service::query_replica_status_handler(const http_request &req,
     // Serialize the replica status into JSON format in preparation for responding to
     // the HTTP request.
     const nlohmann::json json{{"status", status}};
-    resp.status_code = http_status_code::kOk;
-    resp.set_json_body(json.dump());
+    resp.as_ok_json(json.dump());
 }
 
 void replica_http_service::query_app_data_version_handler(const http_request &req,