1

Author: acelyc111

src/meta/test/dump_file.cpp

@@ -24,7 +24,6 @@
  * THE SOFTWARE.
  */
 
-#include <fcntl.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <string.h>

src/utils/logging.cpp

@@ -142,7 +142,6 @@ static void log_on_sys_exit(::dsn::sys_exit_type)
 {
     g_stderr_logger->flush();
     g_file_logger->flush();
-    log_cmds.clear();
 }
 
 void dsn_log_init(const std::string &log_dir, const std::string &role_name)
@@ -151,7 +150,8 @@ void dsn_log_init(const std::string &log_dir, const std::string &role_name)
         "file",
         fmt::format("{}/{}.log", log_dir, role_name.empty() ? FLAGS_base_name : role_name),
         FLAGS_max_log_file_bytes,
-        FLAGS_max_number_of_log_files_on_disk);
+        FLAGS_max_number_of_log_files_on_disk,
+        true /*rotate_on_open*/);
     //    _symlink_path = utils::filesystem::path_combine(_log_dir, symlink_name);
     const auto file_start_level =
         to_spdlog_levels[enum_from_string(FLAGS_logging_start_level, LOG_LEVEL_INVALID)];

src/utils/test/endian_test.cpp

@@ -21,7 +21,6 @@
 
 #include "gtest/gtest.h"
 #include "utils/endians.h"
-#include "utils/enum_helper.h"
 
 using namespace dsn;