fix(replica): fix incorrect error code when secondary replica disk status is abnormal

Author: limowang

java-client/src/main/java/org/apache/pegasus/base/error_code.java

@@ -124,6 +124,8 @@ public enum error_types {
     ERR_PARENT_PARTITION_MISUSED,
     ERR_CHILD_NOT_READY,
     ERR_DISK_INSUFFICIENT,
+    ERR_DISK_IO_ERROR,
+    ERR_SECONDARY_DISK_ABNORMAL,
 
     // ERROR_CODE defined by client
     ERR_SESSION_RESET,

java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java

@@ -2258,6 +2258,13 @@ public void handleReplicaException(
       case ERR_DISK_INSUFFICIENT:
         message = " The replica server disk space is insufficient";
         break;
+      case ERR_DISK_IO_ERROR:
+        message = " The replica server disk I/O error";
+        break;
+      case ERR_SECONDARY_DISK_ABNORMAL:
+        message =
+            " Write rejected: secondary replica disk is abnormal (insufficient space or I/O error)";
+        break;
       default:
         message = " Unknown error!";
         break;

src/replica/replica_2pc.cpp

@@ -183,7 +183,13 @@ void replica::on_client_write(dsn::message_ex *request, bool ignore_throttling)
 
     if (FLAGS_reject_write_when_disk_insufficient &&
         (_dir_node->status != disk_status::NORMAL || _primary_states.secondary_disk_abnormal())) {
-        response_client_write(request, disk_status_to_error_code(_dir_node->status));
+        if (_dir_node->status != disk_status::NORMAL) {
+            // Primary replica disk is abnormal, return the corresponding error code
+            response_client_write(request, disk_status_to_error_code(_dir_node->status));
+        } else {
+            // Secondary replica disk is abnormal but primary is OK
+            response_client_write(request, ERR_SECONDARY_DISK_ABNORMAL);
+        }
         return;
     }
 

src/utils/error_code.h

@@ -189,6 +189,8 @@ DEFINE_ERR_CODE(ERR_HTTP_ERROR)
 
 DEFINE_ERR_CODE(ERR_NOT_MATCHED)
 
+DEFINE_ERR_CODE(ERR_SECONDARY_DISK_ABNORMAL)
+
 } // namespace dsn
 
 USER_DEFINED_STRUCTURE_FORMATTER(::dsn::error_code);