Skip to content

Commit 3f3a384

Browse files
committed
armbian: move Seeed extension clone/pull to post_family_config hook
Move git clone/pull and enable_extension from top-level (runs during config file sourcing) to a proper post_family_config hook. This defers network I/O to the appropriate build phase and avoids side effects during config parsing.
1 parent 7af7c1b commit 3f3a384

1 file changed

Lines changed: 11 additions & 6 deletions

File tree

config/sources/vendors/seeed-studio/recomputer-rk35xx-common.inc

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -300,16 +300,21 @@ EOF
300300
}
301301

302302
# Enable Seeed RK extension (clone/pull + enable_extension)
303-
if [[ "${ENABLE_SEEED_RK_EXTENSION}" == "yes" ]]; then
303+
function post_family_config__seeed_rk_extension_clone_and_enable() {
304+
if [[ "${ENABLE_SEEED_RK_EXTENSION}" != "yes" ]]; then
305+
return 0
306+
fi
307+
304308
if [[ ! -d "${SRC}/extensions/seeed_armbian_extension" ]]; then
305-
echo "[${BOARD_NAME}] Cloning Seeed extensions from GitHub..."
309+
display_alert "Cloning Seeed extensions from GitHub" "$BOARD_NAME" "info"
306310
git clone https://github.com/Seeed-Studio/seeed_armbian_extension.git "${SRC}/extensions/seeed_armbian_extension" || {
307-
echo "[${BOARD_NAME}] Warning: Failed to clone Seeed extensions"
311+
display_alert "Failed to clone Seeed extensions" "$BOARD_NAME" "warn"
312+
return 1
308313
}
309314
else
310-
echo "[${BOARD_NAME}] Seeed extensions already exists, pulling updates..."
311-
git -C "${SRC}/extensions/seeed_armbian_extension" pull || echo "[${BOARD_NAME}] Warning: Failed to pull updates"
315+
display_alert "Seeed extensions already exists, pulling updates" "$BOARD_NAME" "info"
316+
git -C "${SRC}/extensions/seeed_armbian_extension" pull || display_alert "Failed to pull updates" "$BOARD_NAME" "warn"
312317
fi
313318

314319
enable_extension "seeed_armbian_extension"
315-
fi
320+
}

0 commit comments

Comments
 (0)