fix: properly encode values added to mix project

Author: zachdaniel

lib/igniter.ex

@@ -1671,7 +1671,7 @@ defmodule Igniter do
               source,
               igniter,
               :quoted,
-              Sourceror.Zipper.root(zipper),
+              Sourceror.Zipper.topmost_root(zipper),
               by: :configure
             )
           )

lib/igniter/project/mix_project.ex

@@ -256,7 +256,16 @@ defmodule Igniter.Project.MixProject do
         {:ok, zipper} = Common.move_upwards(zipper, &Common.node_matches_pattern?(&1, {_, _}))
         {:ok, Zipper.remove(zipper)}
 
+      {:ok, {:code, quoted}} when is_binary(quoted) ->
+        quoted = Sourceror.parse_string!(quoted)
+        {:ok, Common.replace_code(zipper, quoted)}
+
       {:ok, {:code, quoted}} ->
+        quoted =
+          quoted
+          |> Sourceror.to_string()
+          |> Sourceror.parse_string!()
+
         {:ok, Common.replace_code(zipper, quoted)}
 
       other ->

mix.lock

@@ -14,7 +14,7 @@
   "file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},
   "finch": {:hex, :finch, "0.19.0", "c644641491ea854fc5c1bbaef36bfc764e3f08e7185e1f084e35e0672241b76d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.6.2 or ~> 1.7", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "fc5324ce209125d1e2fa0fcd2634601c52a787aff1cd33ee833664a5af4ea2b6"},
   "git_cli": {:hex, :git_cli, "0.3.0", "a5422f9b95c99483385b976f5d43f7e8233283a47cda13533d7c16131cb14df5", [:mix], [], "hexpm", "78cb952f4c86a41f4d3511f1d3ecb28edb268e3a7df278de2faa1bd4672eaf9b"},
-  "git_ops": {:git, "https://github.com/zachdaniel/git_ops.git", "075380d3dc81e80b37d02195184a784b0c0dd7a7", [branch: "no-igniter"]},
+  "git_ops": {:git, "https://github.com/zachdaniel/git_ops.git", "ac7a420a855f2e7407f254055577c88b5b828632", [branch: "no-igniter"]},
   "glob_ex": {:hex, :glob_ex, "0.1.11", "cb50d3f1ef53f6ca04d6252c7fde09fd7a1cf63387714fe96f340a1349e62c93", [:mix], [], "hexpm", "342729363056e3145e61766b416769984c329e4378f1d558b63e341020525de4"},
   "ham": {:hex, :ham, "0.3.0", "7cd031b4a55fba219c11553e7b13ba73bd86eab4034518445eff1e038cb9a44d", [:mix], [], "hexpm", "7d6c6b73d7a6a83233876cc1b06a4d9b5de05562b228effda4532f9a49852bf6"},
   "hpax": {:hex, :hpax, "1.0.3", "ed67ef51ad4df91e75cc6a1494f851850c0bd98ebc0be6e81b026e765ee535aa", [:mix], [], "hexpm", "8eab6e1cfa8d5918c2ce4ba43588e894af35dbd8e91e6e55c817bca5847df34a"},

test/igniter/project/mix_project_test.exs

@@ -20,6 +20,24 @@ defmodule Igniter.Project.MixProjectTest do
       """)
     end
 
+    test "doesn't strip lists when setting compilers" do
+      test_project()
+      |> Igniter.Project.MixProject.update(:project, [:compilers], fn
+        nil ->
+          {:ok,
+           {:code,
+            quote do
+              [:phoenix_live_view] ++ Mix.compilers()
+            end}}
+
+        _zipper ->
+          raise "nope"
+      end)
+      |> assert_has_patch("mix.exs", """
+      + | compilers: [:phoenix_live_view] ++ Mix.compilers()
+      """)
+    end
+
     test "updates with a code tuple" do
       test_project()
       |> MixProject.update(:project, [:version], fn _zipper ->