Remove vestigial _ensure_minimal_target shim

The shim was needed during the asn-as-targets / scope-rework work where
Scanner.helpers fell back to self._unbaked_preset.helpers when self.preset
was None. On this branch Scanner.__init__ synchronously bakes the preset,
so by the time anyone reads .helpers the target already exists. Verified
by sticking a raise inside _ensure_minimal_target and running step_1 +
sample module tests + bbot --help/--list-modules — never fired.

Author: liquidsec

bbot/scanner/preset/preset.py

@@ -588,34 +588,11 @@ def apply_log_level(self, apply_core=False):
     @property
     def helpers(self):
         if self._helpers is None:
-            # Ensure we have at least a minimal target object before any helper (especially web helpers) is constructed.
-
-            self._ensure_minimal_target()
             from bbot.core.helpers.helper import ConfigAwareHelper
 
             self._helpers = ConfigAwareHelper(preset=self)
         return self._helpers
 
-    def _ensure_minimal_target(self):
-        """
-        Lazily construct a minimal BBOTTarget from the current seeds / whitelist / blacklist if one does not already exist.
-
-        This is intentionally lighter-weight than the full async target
-        preparation performed in `bake()` (which also calls
-        `target.generate_children()`).
-        """
-        if self._target is not None:
-            return
-
-        from bbot.scanner.target import BBOTTarget
-
-        self._target = BBOTTarget(
-            *list(self._seeds),
-            whitelist=self._whitelist,  # modify this after scope rework branch is merged into dev
-            blacklist=self._blacklist,
-            strict_scope=self.strict_scope,
-        )
-
     @property
     def module_loader(self):
         self.environ