Stop cstring reading on any falsy value

brianc · brianc · commit 8794fcd73d52 · 2026-06-17T16:02:20.000-05:00
diff --git a/.gitignore b/.gitignore
@@ -10,3 +10,4 @@ dist
 /.eslintcache
 .vscode/
 manually-test-on-heroku.js
+tsconfig.tsbuildinfo
diff --git a/packages/pg-protocol/src/buffer-reader.ts b/packages/pg-protocol/src/buffer-reader.ts
@@ -45,7 +45,7 @@ export class BufferReader {
     const start = this.offset
     let end = start
     // eslint-disable-next-line no-empty
-    while (this.buffer[end++] !== 0) {}
+    while (this.buffer[end++]) {}
     this.offset = end
     return this.buffer.toString(this.encoding, start, end - 1)
   }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export class BufferReader {`
`45`	`45`	`const start = this.offset`
`46`	`46`	`let end = start`
`47`	`47`	`// eslint-disable-next-line no-empty`
`48`		`- while (this.buffer[end++] !== 0) {}`
	`48`	`+ while (this.buffer[end++]) {}`
`49`	`49`	`this.offset = end`
`50`	`50`	`return this.buffer.toString(this.encoding, start, end - 1)`
`51`	`51`	`}`