assert on both errors and move to unhandled feature

Author: gingerbenw

packages/plugin-hono/src/hono.js

@@ -37,15 +37,12 @@ module.exports = {
     })
 
     const errorHandler = createMiddleware(async (c, next) => {
-      let rethrow = false
-
       try {
         // Catch non-errors thrown in routes without causing the route to hang by awaiting the next() call inside a try/catch block.
         // The error is then attached to the context and processed in the same way as errors thrown in routes.
         await next()
       } catch (err) {
         c.error = err
-        rethrow = true
       }
 
       if (!c.error) return
@@ -65,8 +62,6 @@ module.exports = {
           client._notify(event)
         }
       }
-
-      if (rethrow) throw c.error
     })
 
     return { requestHandler, errorHandler }

test/aws-lambda/features/promise-rejection.feature

@@ -111,30 +111,3 @@ Scenario: promise rejections are reported when using hono
     Then the session is valid for the session reporting API version "1" for the "Bugsnag Node" notifier
     And the session "id" is not null
     And the session "startedAt" is a timestamp
-
-@hono-app
-Scenario Outline: thrown non-error exceptions are reported when using hono
-    Given I setup the environment
-    When I invoke the "HonoFunction" lambda in "features/fixtures/hono-app" with the "events/throw-non-error.json" event
-    Then the lambda response "errorMessage" equals "1"
-    And the lambda response "errorType" equals "number"
-    And the lambda response "body" is null
-    And the lambda response "statusCode" is null
-    And the SAM exit code equals 0
-    When I wait to receive an error
-    Then the error is valid for the error reporting API version "4" for the "Bugsnag Node" notifier
-    And the event "unhandled" is true
-    And the event "severity" equals "error"
-    And the event "severityReason.type" equals "unhandledErrorMiddleware"
-    And the exception "errorClass" equals "InvalidError"
-    And the exception "message" matches "unhandledErrorMiddleware handler received a non-error\."
-    And the exception "type" equals "nodejs"
-    And the event "metaData.AWS Lambda context.functionName" equals "HonoFunction"
-    And the event "metaData.AWS Lambda context.awsRequestId" is not null
-    And the event "device.runtimeVersions.node" matches "^18\.\d+\.\d+$"
-    When I wait to receive a session
-    Then the session is valid for the session reporting API version "1" for the "Bugsnag Node" notifier
-    And the session "id" is not null
-    And the session "startedAt" is a timestamp
-    And the event "session.events.handled" equals 0
-    And the event "session.events.unhandled" equals 1

test/aws-lambda/features/unhandled.feature

@@ -179,3 +179,44 @@ Scenario Outline: unhandled asynchronous exceptions are reported when using hono
     And the event "session.events.handled" equals 0
     And the event "session.events.unhandled" equals 1
 
+@hono-app
+Scenario Outline: thrown non-error exceptions are reported when using hono
+    Given I setup the environment
+    When I invoke the "HonoFunction" lambda in "features/fixtures/hono-app" with the "events/throw-non-error.json" event
+    Then the lambda response "errorMessage" equals "1"
+    And the lambda response "errorType" equals "number"
+    And the lambda response "body" is null
+    And the lambda response "statusCode" is null
+    And the SAM exit code equals 0
+    When I wait to receive 2 errors
+
+    Then the error is valid for the error reporting API version "4" for the "Bugsnag Node" notifier
+    And the event "unhandled" is true
+    And the event "severity" equals "error"
+    And the event "severityReason.type" equals "unhandledException"
+    And the exception "errorClass" equals "Error"
+    And the exception "message" equals "1"
+    And the exception "type" equals "nodejs"
+    And the event "metaData.AWS Lambda context.functionName" equals "HonoFunction"
+    And the event "metaData.AWS Lambda context.awsRequestId" is not null
+    And the event "device.runtimeVersions.node" matches "^18\.\d+\.\d+$"
+
+    # Error thrown by hono
+    And I discard the oldest error
+    Then the error is valid for the error reporting API version "4" for the "Bugsnag Node" notifier
+    And the event "unhandled" is true
+    And the event "severity" equals "error"
+    And the event "severityReason.type" equals "unhandledErrorMiddleware"
+    And the exception "errorClass" equals "InvalidError"
+    And the exception "message" matches "hono middleware received a non-error\."
+    And the exception "type" equals "nodejs"
+    And the event "metaData.AWS Lambda context.functionName" equals "HonoFunction"
+    And the event "metaData.AWS Lambda context.awsRequestId" is not null
+    And the event "device.runtimeVersions.node" matches "^18\.\d+\.\d+$"
+
+    When I wait to receive a session
+    Then the session is valid for the session reporting API version "1" for the "Bugsnag Node" notifier
+    And the session "id" is not null
+    And the session "startedAt" is a timestamp
+    And the event "session.events.handled" equals 0
+    And the event "session.events.unhandled" equals 1