From d0d3fbb978ca1d027154b0b8d9211d2464c755b6 Mon Sep 17 00:00:00 2001 From: Vamsi Date: Sun, 1 Mar 2026 16:44:02 -0600 Subject: [PATCH] annotation: make GeneratedAppGlideModuleImpl public to fix Kotlin 2.2.20 visibility warning (#5601) --- .../glide/annotation/compiler/AppModuleGenerator.java | 4 ++-- .../GeneratedAppGlideModuleImpl.java | 2 +- .../GeneratedAppGlideModuleImpl.java | 2 +- .../GeneratedAppGlideModuleImpl.java | 2 +- .../GeneratedAppGlideModuleImpl.java | 2 +- .../EmptyAppGlideModuleTest/GeneratedAppGlideModuleImpl.java | 2 +- .../main/java/com/bumptech/glide/GeneratedAppGlideModule.java | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleGenerator.java b/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleGenerator.java index 4a2aabcae5..f62a278eb9 100644 --- a/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleGenerator.java +++ b/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleGenerator.java @@ -39,7 +39,7 @@ * * 
  * 
- *  final class GeneratedAppGlideModuleImpl extends com.bumptech.glide.GeneratedAppGlideModule {
+ *  public final class GeneratedAppGlideModuleImpl extends com.bumptech.glide.GeneratedAppGlideModule {
  *    private final com.bumptech.glide.samples.giphy.GiphyGlideModule appGlideModule;
  *
  *    GeneratedAppGlideModule() {
@@ -141,7 +141,7 @@ TypeSpec generate(TypeElement appGlideModule, Set libraryGlideModuleClas
 
     Builder builder =
         TypeSpec.classBuilder(GENERATED_APP_MODULE_IMPL_SIMPLE_NAME)
-            .addModifiers(Modifier.FINAL)
+            .addModifiers(Modifier.PUBLIC, Modifier.FINAL)
             .addAnnotation(
                 AnnotationSpec.builder(SuppressWarnings.class)
                     .addMember("value", "$S", "deprecation")
diff --git a/annotation/compiler/test/src/test/resources/AppGlideModuleWithExcludesTest/GeneratedAppGlideModuleImpl.java b/annotation/compiler/test/src/test/resources/AppGlideModuleWithExcludesTest/GeneratedAppGlideModuleImpl.java
index 37c370dd32..c1408a666e 100644
--- a/annotation/compiler/test/src/test/resources/AppGlideModuleWithExcludesTest/GeneratedAppGlideModuleImpl.java
+++ b/annotation/compiler/test/src/test/resources/AppGlideModuleWithExcludesTest/GeneratedAppGlideModuleImpl.java
@@ -8,7 +8,7 @@
 import java.util.Set;
 
 @SuppressWarnings("deprecation")
-final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
+public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
   private final AppModuleWithExcludes appGlideModule;
 
   public GeneratedAppGlideModuleImpl(Context context) {
diff --git a/annotation/compiler/test/src/test/resources/AppGlideModuleWithLibraryInPackageTest/GeneratedAppGlideModuleImpl.java b/annotation/compiler/test/src/test/resources/AppGlideModuleWithLibraryInPackageTest/GeneratedAppGlideModuleImpl.java
index f2ad77e022..db463ece89 100644
--- a/annotation/compiler/test/src/test/resources/AppGlideModuleWithLibraryInPackageTest/GeneratedAppGlideModuleImpl.java
+++ b/annotation/compiler/test/src/test/resources/AppGlideModuleWithLibraryInPackageTest/GeneratedAppGlideModuleImpl.java
@@ -8,7 +8,7 @@
 import java.util.Set;
 
 @SuppressWarnings("deprecation")
-final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
+public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
   private final AppModuleWithLibraryInPackage appGlideModule;
 
   public GeneratedAppGlideModuleImpl(Context context) {
diff --git a/annotation/compiler/test/src/test/resources/AppGlideModuleWithMultipleExcludesTest/GeneratedAppGlideModuleImpl.java b/annotation/compiler/test/src/test/resources/AppGlideModuleWithMultipleExcludesTest/GeneratedAppGlideModuleImpl.java
index c0f30f3838..69e0ede4c3 100644
--- a/annotation/compiler/test/src/test/resources/AppGlideModuleWithMultipleExcludesTest/GeneratedAppGlideModuleImpl.java
+++ b/annotation/compiler/test/src/test/resources/AppGlideModuleWithMultipleExcludesTest/GeneratedAppGlideModuleImpl.java
@@ -8,7 +8,7 @@
 import java.util.Set;
 
 @SuppressWarnings("deprecation")
-final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
+public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
   private final AppModuleWithMultipleExcludes appGlideModule;
 
   public GeneratedAppGlideModuleImpl(Context context) {
diff --git a/annotation/compiler/test/src/test/resources/EmptyAppAndLibraryGlideModulesTest/GeneratedAppGlideModuleImpl.java b/annotation/compiler/test/src/test/resources/EmptyAppAndLibraryGlideModulesTest/GeneratedAppGlideModuleImpl.java
index d8e26dbdf7..e2009aa3d5 100644
--- a/annotation/compiler/test/src/test/resources/EmptyAppAndLibraryGlideModulesTest/GeneratedAppGlideModuleImpl.java
+++ b/annotation/compiler/test/src/test/resources/EmptyAppAndLibraryGlideModulesTest/GeneratedAppGlideModuleImpl.java
@@ -9,7 +9,7 @@
 import java.util.Set;
 
 @SuppressWarnings("deprecation")
-final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
+public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
   private final EmptyAppModule appGlideModule;
 
   public GeneratedAppGlideModuleImpl(Context context) {
diff --git a/annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest/GeneratedAppGlideModuleImpl.java b/annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest/GeneratedAppGlideModuleImpl.java
index c5e014dded..18ab9f81a8 100644
--- a/annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest/GeneratedAppGlideModuleImpl.java
+++ b/annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest/GeneratedAppGlideModuleImpl.java
@@ -8,7 +8,7 @@
 import java.util.Set;
 
 @SuppressWarnings("deprecation")
-final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
+public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
   private final EmptyAppModule appGlideModule;
 
   public GeneratedAppGlideModuleImpl(Context context) {
diff --git a/library/src/main/java/com/bumptech/glide/GeneratedAppGlideModule.java b/library/src/main/java/com/bumptech/glide/GeneratedAppGlideModule.java
index 04d0f1ec2c..162891ee9d 100644
--- a/library/src/main/java/com/bumptech/glide/GeneratedAppGlideModule.java
+++ b/library/src/main/java/com/bumptech/glide/GeneratedAppGlideModule.java
@@ -13,7 +13,7 @@
  * processing system and optionally provides a {@link
  * com.bumptech.glide.manager.RequestManagerRetriever.RequestManagerFactory} impl.
  */
-abstract class GeneratedAppGlideModule extends AppGlideModule {
+public abstract class GeneratedAppGlideModule extends AppGlideModule {
   /** This method can be removed when manifest parsing is no longer supported. */
   @NonNull
   Set> getExcludedModuleClasses() {