Skip to content

Add support for paragraph like editor.#675

Open
Mati365 wants to merge 21 commits into
masterfrom
ck/9933
Open

Add support for paragraph like editor.#675
Mati365 wants to merge 21 commits into
masterfrom
ck/9933

Conversation

@Mati365
Copy link
Copy Markdown
Member

@Mati365 Mati365 commented May 18, 2026

Comment thread src/multiroot/EditorEditable.tsx
Comment thread src/ckeditor.tsx Outdated
Comment thread src/multiroot/EditorEditable.tsx
Comment thread src/multiroot/useMultiRootEditor.tsx Outdated
Comment thread src/multiroot/useMultiRootEditor.tsx Outdated
Comment thread src/multiroot/useMultiRootEditor.tsx Outdated
Comment thread src/multiroot/useMultiRootEditor.tsx Outdated
Comment thread src/multiroot/useMultiRootEditor.tsx
Comment thread src/multiroot/useMultiRootEditor.tsx Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 173064c. Configure here.

Comment thread src/multiroot/EditorEditable.tsx Outdated
@Mati365 Mati365 requested a review from gorzelinski May 22, 2026 07:21
Copy link
Copy Markdown
Contributor

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides those suggestions, I also found two occurrences of ckbox in version 2.9.2. It's not the newest one. I'm unsure if that's intentional.

Comment thread src/ckeditor.tsx
*/
public override render(): React.ReactNode {
const { editor: Editor, config = {} } = this.props;
const definition = getEditorElementDefinition( Editor, config );
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about type safety here. In case of typo or passing a number, there won't be a proper error. We could narrow the type or reject more invalid shapes during normalization.

Comment thread src/ckeditor.tsx
Comment thread src/multiroot/EditorEditable.tsx
Comment thread tests/EditorElement.test.tsx
Comment thread src/multiroot/useMultiRootEditor.tsx
Comment thread src/EditorElement.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants